Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 544945

Summary: Onboarding Text can be blank if contributed item has no tooltip or description
Product: [Eclipse Project] Platform Reporter: Jonah Graham <jonah>
Component: UIAssignee: Jonah Graham <jonah>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, jonah, ma.becker
Version: 4.11Flags: daniel_megert: pmc_approved+
Target Milestone: 4.11 RC2   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=543746
https://git.eclipse.org/r/137855
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac93f51cfc5352c24baa84b54713f911ff1d250f
Whiteboard:
Bug Depends on: 543746    
Bug Blocks:    
Attachments:
Description Flags
screenshot of missing text none

Description Jonah Graham CLA 2019-03-01 06:21:07 EST 
Created attachment 277731 [details]
screenshot of missing text

If a contribution for the new project wizard has neither a tooltip or a description then the text is blank in the Project Explorer. See screenshot for an example of what we had in CDT in Bug 544944
Comment 1 Jonah Graham CLA 2019-03-01 06:22:36 EST 
I have fixed (in progress) CDT's case. However for other uses I propose falling back on the Text, which is what appears in the File -> New menu.

Patch on the way.
Comment 2 Eclipse Genie CLA 2019-03-01 06:28:30 EST 
New Gerrit change created: https://git.eclipse.org/r/137855
Comment 3 Dani Megert CLA 2019-03-01 08:46:15 EST 
I approve for RC2.
Comment 4 Matthias Becker CLA 2019-03-01 09:52:56 EST 

(In reply to Dani Megert from comment #3)
> I approve for RC2.

+1 on gerrit from my side
Comment 5 Dani Megert CLA 2019-03-01 09:59:37 EST 
(In reply to Matthias Becker from comment #4)
> 
> (In reply to Dani Megert from comment #3)
> > I approve for RC2.
> 
> +1 on gerrit from my side
Can you give a 2+ and merge please.
Comment 7 Matthias Becker CLA 2019-03-01 10:02:53 EST 
(In reply to Dani Megert from comment #5)
> (In reply to Matthias Becker from comment #4)
> > 
> > (In reply to Dani Megert from comment #3)
> > > I approve for RC2.
> > 
> > +1 on gerrit from my side
> Can you give a 2+ and merge please.

Done.
Thans to: Jonah for reporting and Michael for fixing.
Comment 8 Dani Megert CLA 2019-03-01 10:07:50 EST 
(In reply to Matthias Becker from comment #7)
> (In reply to Dani Megert from comment #5)
> > (In reply to Matthias Becker from comment #4)
> > > 
> > > (In reply to Dani Megert from comment #3)
> > > > I approve for RC2.
> > > 
> > > +1 on gerrit from my side
> > Can you give a 2+ and merge please.
> 
> Done.
> Thans to: Jonah for reporting and Michael for fixing.
Jonah fixed it ;-)
Comment 9 Matthias Becker CLA 2019-03-01 10:09:22 EST 
(In reply to Dani Megert from comment #8)
> (In reply to Matthias Becker from comment #7)
> > (In reply to Dani Megert from comment #5)
> > > (In reply to Matthias Becker from comment #4)
> > > > 
> > > > (In reply to Dani Megert from comment #3)
> > > > > I approve for RC2.
> > > > 
> > > > +1 on gerrit from my side
> > > Can you give a 2+ and merge please.
> > 
> > Done.
> > Thans to: Jonah for reporting and Michael for fixing.
> Jonah fixed it ;-)

You are right. Sorry. 
Jonah thanks for reporting *AND* fixing. Thanks Michael for the review.
Comment 10 Jonah Graham CLA 2019-03-01 15:46:13 EST 
(In reply to Matthias Becker from comment #9)
> Jonah thanks for reporting *AND* fixing. Thanks Michael for the review.

My pleasure. It is a nice new feature you added. It really makes the UX nicer to not start with completely empty big views.