Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 544696

Summary: Deploy ecj compiler from M3 (I20190220-1800) and use it for 4.11 RC1 build
Product: [Eclipse Project] Platform Reporter: Niraj Modi <niraj.modi>
Component: RelengAssignee: Niraj Modi <niraj.modi>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, sravankumarl, stephan.herrmann
Version: 4.11   
Target Milestone: 4.11 RC1   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/137425
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=706299ec976166db130e46f0211cabc019544440
https://git.eclipse.org/r/137438
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=9b38a19e8eb76ed9835d05664ee30b32a0b5a8c2
https://git.eclipse.org/r/137467
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=9408326188b27b7dc419a2f72c84324ba218c02d
Whiteboard:
Bug Depends on:    
Bug Blocks: 543666    

Description Niraj Modi CLA 2019-02-22 02:56:25 EST
Deploy and update JDT core compiler and apt compiler to use 4.11M3 to produce 4.11RC1
Comment 1 Eclipse Genie CLA 2019-02-22 03:37:28 EST
New Gerrit change created: https://git.eclipse.org/r/137425
Comment 3 Niraj Modi CLA 2019-02-22 04:43:26 EST
Triggered a test Eclipse IBuild for verification:
BUILD_ID was defined as I20190222-0440
Comment 4 Niraj Modi CLA 2019-02-22 06:03:57 EST
(In reply to Niraj Modi from comment #3)
> Triggered a test Eclipse IBuild for verification:
> BUILD_ID was defined as I20190222-0440

Above build failed, will have to revert the ECJ change. Sharing the failure message from the IBuild:
https://download.eclipse.org/eclipse/downloads/drops4/I20190222-0440/buildFailed-run-maven-build
Comment 5 Eclipse Genie CLA 2019-02-22 06:12:29 EST
New Gerrit change created: https://git.eclipse.org/r/137438
Comment 7 Niraj Modi CLA 2019-02-22 06:49:38 EST
(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/137438 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=9b38a19e8eb76ed9835d05664ee30b32a0b5a8c2

After reverting the ECJ, triggered a fresh IBuild: I20190222-0645
Comment 8 Niraj Modi CLA 2019-02-22 09:17:19 EST
(In reply to Niraj Modi from comment #7)
> (In reply to Eclipse Genie from comment #6)
> > Gerrit change https://git.eclipse.org/r/137438 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> > commit/?id=9b38a19e8eb76ed9835d05664ee30b32a0b5a8c2
> 
> After reverting the ECJ, triggered a fresh IBuild: I20190222-0645

Above build is good:
http://download.eclipse.org/eclipse/downloads/drops4/I20190222-0645/

We try and update to the latest ECJ on coming Monday.
Comment 9 Stephan Herrmann CLA 2019-02-22 09:24:20 EST
(In reply to Niraj Modi from comment #4)
> (In reply to Niraj Modi from comment #3)
> > Triggered a test Eclipse IBuild for verification:
> > BUILD_ID was defined as I20190222-0440
> 
> Above build failed, will have to revert the ECJ change. Sharing the failure
> message from the IBuild:
> https://download.eclipse.org/eclipse/downloads/drops4/I20190222-0440/
> buildFailed-run-maven-build

Given this error "Fatal error compiling: Timeout 30 s exceeded."
do you have any indication that this was caused by the ecj update, rather than an infra glitch? Did it fail more than once?
Comment 10 Dani Megert CLA 2019-02-22 09:32:27 EST
(In reply to Niraj Modi from comment #8)
> (In reply to Niraj Modi from comment #7)
> > (In reply to Eclipse Genie from comment #6)
> > > Gerrit change https://git.eclipse.org/r/137438 was merged to [master].
> > > Commit:
> > > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> > > commit/?id=9b38a19e8eb76ed9835d05664ee30b32a0b5a8c2
> > 
> > After reverting the ECJ, triggered a fresh IBuild: I20190222-0645
> 
> Above build is good:
> http://download.eclipse.org/eclipse/downloads/drops4/I20190222-0645/
> 
> We try and update to the latest ECJ on coming Monday.
Please do this now to verify Stephan's theory. We are in RC1 next week, so, time is an issue.
Comment 11 Niraj Modi CLA 2019-02-22 11:54:15 EST
(In reply to Stephan Herrmann from comment #9)
> (In reply to Niraj Modi from comment #4)
> > (In reply to Niraj Modi from comment #3)
> > > Triggered a test Eclipse IBuild for verification:
> > > BUILD_ID was defined as I20190222-0440
> > 
> > Above build failed, will have to revert the ECJ change. Sharing the failure
> > message from the IBuild:
> > https://download.eclipse.org/eclipse/downloads/drops4/I20190222-0440/
> > buildFailed-run-maven-build
> 
> Given this error "Fatal error compiling: Timeout 30 s exceeded."
> do you have any indication that this was caused by the ecj update, rather
> than an infra glitch? Did it fail more than once?

Ok, let me try the latest ECJ a second time to confirm the same.

(In reply to Dani Megert from comment #10)
> (In reply to Niraj Modi from comment #8)
> > (In reply to Niraj Modi from comment #7)
> > > (In reply to Eclipse Genie from comment #6)
> > > > Gerrit change https://git.eclipse.org/r/137438 was merged to [master].
> > > > Commit:
> > > > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> > > > commit/?id=9b38a19e8eb76ed9835d05664ee30b32a0b5a8c2
> > > 
> > > After reverting the ECJ, triggered a fresh IBuild: I20190222-0645
> > 
> > Above build is good:
> > http://download.eclipse.org/eclipse/downloads/drops4/I20190222-0645/
> > 
> > We try and update to the latest ECJ on coming Monday.
> Please do this now to verify Stephan's theory. We are in RC1 next week, so,
> time is an issue.
Sure, I try an IBuild shortly.
Comment 12 Eclipse Genie CLA 2019-02-22 11:55:14 EST
New Gerrit change created: https://git.eclipse.org/r/137467
Comment 13 Niraj Modi CLA 2019-02-22 12:04:42 EST
(In reply to Eclipse Genie from comment #12)
> New Gerrit change created: https://git.eclipse.org/r/137467

Will wait for Gerrit validation to complete.
Comment 15 Niraj Modi CLA 2019-02-23 07:22:13 EST
(In reply to Niraj Modi from comment #13)
> (In reply to Eclipse Genie from comment #12)
> > New Gerrit change created: https://git.eclipse.org/r/137467
> 
> Will wait for Gerrit validation to complete.

Gerrit validation passed in second attempt, merged the change now.
So, next IBuild scheduled at 1800(i.e. I20190223-1800) time later today will be using latest ECJ from M3.
Comment 16 Dani Megert CLA 2019-02-23 08:49:15 EST
(In reply to Niraj Modi from comment #15)
> (In reply to Niraj Modi from comment #13)
> > (In reply to Eclipse Genie from comment #12)
> > > New Gerrit change created: https://git.eclipse.org/r/137467
> > 
> > Will wait for Gerrit validation to complete.
> 
> Gerrit validation passed in second attempt, merged the change now.
> So, next IBuild scheduled at 1800(i.e. I20190223-1800) time later today will
> be using latest ECJ from M3.
That worked.