Bugzilla – Full Text Bug Listing
| Summary: | [formatting] Operators not displayed correctly on profile page | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Noopur Gupta <noopur_gupta> | ||||
| Component: | UI | Assignee: | Noopur Gupta <noopur_gupta> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, mateusz.matela, sarika.sinha | ||||
| Version: | 4.11 | Flags: | sarika.sinha:
review+
|
||||
| Target Milestone: | 4.11 RC1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/137512 https://git.eclipse.org/r/137513 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=82f4e5e641fe9e1f4161bab38df6c86da200aa04 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=dc02907d4b214a0624cc0f100ea567597c2e6af0 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 543475 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Mateusz, please fix this and also update the N&N screenshot. For M3, this should be fixed today before 18:00 Eastern Time. Otherwise, it should be released after M3 is declared for RC1 with another +1 from the project lead. N&N can be updated anytime. Also, N&N says, "The new Binary expressions subsection..." whereas it should be "Binary operators". (In reply to Noopur Gupta from comment #1) > Mateusz, please fix this and also update the N&N screenshot. > > For M3, this should be fixed today before 18:00 Eastern Time. Otherwise, it > should be released after M3 is declared for RC1 with another +1 from the > project lead. > > N&N can be updated anytime. > Also, N&N says, "The new Binary expressions > subsection..." whereas it should be "Binary operators". I have updated the N&N text. New Gerrit change created: https://git.eclipse.org/r/137512 New Gerrit change created: https://git.eclipse.org/r/137513 Looks good for RC1. Gerrit change https://git.eclipse.org/r/137512 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=82f4e5e641fe9e1f4161bab38df6c86da200aa04 Gerrit change https://git.eclipse.org/r/137513 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=dc02907d4b214a0624cc0f100ea567597c2e6af0 Thanks, Sarika. Released the fix and updated the N&N screenshot for RC1. I thought the N&N screenshot better presented the concept when some checkboxes were not checked. Also, your version has a different font size, maybe it would be better to keep it consistent at least between the formatter screenshots. Shall I upload my version of the screenshot? (In reply to Mateusz Matela from comment #9) > Shall I upload my version of the screenshot? Yes, please update. (In reply to Noopur Gupta from comment #10) > Yes, please update. Done. Verified in I20190226-1800. |
Created attachment 277630 [details] Screenshot I20190219-1800 Under Binary Operators on the formatter profile, the operators are not displayed correctly. See attached screenshot. - In first two, the first operator is missing. - In last two, '&' is shown as a logical operator which is wrong.