Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 544606

Summary:	Disabled button text not visible in dark theme on Mac
Product:	[Eclipse Project] Platform	Reporter:	Lakshmi P Shanmugam <lshanmug>
Component:	UI	Assignee:	Till Brychcy <register.eclipse>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel, lshanmug, register.eclipse
Version:	4.11
Target Milestone:	4.11 RC1
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/137246 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=94519cab94d972759c797b69d211b623fc8d7808 https://git.eclipse.org/r/137312 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=84d789c50355ce6e14c04da6bb9b68de1f808279 https://git.eclipse.org/r/137337 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6d90c60abee2b10c79a55d404cb75d876e0c5e01
Whiteboard:
Bug Depends on:
Bug Blocks:	544854

Description Lakshmi P Shanmugam

2019-02-20 01:37:04 EST

Build id: I20190218-1800

The text of the disabled button is barely visible in Eclipse Dark Theme on Mac.
This is because the foreground color button is set and is very close to the background color.
Fix is to not set the foreground color of the button so that it can use the default from the OS, similar to the background color.

Comment 1 Eclipse Genie

2019-02-20 01:44:30 EST

New Gerrit change created: https://git.eclipse.org/r/137246

Comment 2 Eclipse Genie

2019-02-20 04:32:00 EST

Gerrit change https://git.eclipse.org/r/137246 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=94519cab94d972759c797b69d211b623fc8d7808

Comment 3 Till Brychcy

2019-02-20 05:02:17 EST

With this change, the buttons in the git staging view have a black foreground color.

Comment 4 Dani Megert

2019-02-20 05:38:12 EST

(In reply to Till Brychcy from comment #3)
> With this change, the buttons in the git staging view have a black
> foreground color.
So, should this be reopened?

Comment 5 Till Brychcy

2019-02-20 05:46:37 EST

Reopening

Comment 6 Lakshmi P Shanmugam

2019-02-20 06:23:51 EST

Thanks Till, I can see the problem, investigating...

Comment 7 Lakshmi P Shanmugam

2019-02-20 09:27:51 EST

I looked at this, the buttons in Eclipse are not affected. Only the text color of enabled buttons in Git Staging view are affected. They are flat style buttons, so the background color is different. May be the foreground color is explicitly set in EGit and has to be fixed there.
Or we may have to set the foreground color explicitly in the e4 css style sheets.

@Till, what do you suggest?

Comment 8 Lakshmi P Shanmugam

2019-02-20 09:41:39 EST

(In reply to Lakshmi Shanmugam from comment #7)
> I looked at this, the buttons in Eclipse are not affected. Only the text
> color of enabled buttons in Git Staging view are affected. They are flat
> style buttons, so the background color is different. May be the foreground
> color is explicitly set in EGit and has to be fixed there.
> Or we may have to set the foreground color explicitly in the e4 css style
> sheets.
> 
> @Till, what do you suggest?

Ok, after debugging I found that it affects all the buttons in Forms. So, the Manifest editor in Eclipse is affected too.

Comment 9 Lakshmi P Shanmugam

2019-02-20 12:35:42 EST

I'll revert this change for M3 as it affects the Buttons in Forms. Will work on a fix for RC1.

Comment 10 Eclipse Genie

2019-02-20 12:37:42 EST

New Gerrit change created: https://git.eclipse.org/r/137312

Comment 11 Eclipse Genie

2019-02-20 13:02:25 EST

Gerrit change https://git.eclipse.org/r/137312 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=84d789c50355ce6e14c04da6bb9b68de1f808279

Comment 12 Eclipse Genie

2019-02-21 02:53:36 EST

New Gerrit change created: https://git.eclipse.org/r/137337

Comment 13 Till Brychcy

2019-02-21 02:57:48 EST

(In reply to Eclipse Genie from comment #12)
> New Gerrit change created: https://git.eclipse.org/r/137337

null was explicitly disallowed by the css handler that sets the foreground color.

Comment 14 Lakshmi P Shanmugam

2019-02-21 04:20:08 EST

(In reply to Till Brychcy from comment #13)
> (In reply to Eclipse Genie from comment #12)
> > New Gerrit change created: https://git.eclipse.org/r/137337
> 
> null was explicitly disallowed by the css handler that sets the foreground
> color.

Thanks for finding the problem and fix, Till!
I tested the patch and it fixes the problem with disabled buttons and text color of Form buttons look good too.

Comment 15 Lars Vogel

2019-02-23 15:24:37 EST

+1 from project lead

Comment 16 Eclipse Genie

2019-02-23 16:11:23 EST

Gerrit change https://git.eclipse.org/r/137337 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6d90c60abee2b10c79a55d404cb75d876e0c5e01

Comment 17 Till Brychcy

2019-02-23 16:11:44 EST

(In reply to Eclipse Genie from comment #16)
> Gerrit change https://git.eclipse.org/r/137337 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=6d90c60abee2b10c79a55d404cb75d876e0c5e01

Released for 4.11RC1

Comment 18 Lakshmi P Shanmugam

2019-02-27 06:16:03 EST

Verified in I20190226-1800.