Bugzilla – Full Text Bug Listing
| Summary: | Onboarding text: looks bad in default light theme on Linux when view inactive | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Wolf <twolf> | ||||||
| Component: | IDE | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, ma.becker, marcus.hoepfner | ||||||
| Version: | 4.11 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=546673 | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 514649, 543746 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Thomas Wolf
Matthias, please have a look. (In reply to Thomas Wolf from comment #0) > Created attachment 277577 [details] > Inactive project explorer on empty workspace > > View background turns gray, but hyperlinks keep white background. > > CentOS 7, Linux 3.10.0-693.5.2.el7.x86_64, X11, Adwaita, GTK 3.22.10. > > Eclipse build ID: 4.11.0.I20190212-1800 > > Same behavior in the package explorer. > > Perhaps related: bug 514649. Maybe that inactive view shouldn't change its > background at all? (The Git repositories view doesn't...) It _is_ a CSS > problem; without theme, the view background stays white. > > (As an aside, what's the white area in the Outline toolbar? That's another > CSS problem; without theme this white area is not there.) Hi Thomas, how did you get an inactive grey project explorer? When I open the About Dialog, my Project Explorer gets inactive like the whole Workbench Window, but it does not turn into grey. I clicked on the outline tab. Opened the about dialog later to show the build ID in the screenshot. (In reply to Thomas Wolf from comment #0) > Created attachment 277577 [details] > Inactive project explorer on empty workspace > > View background turns gray, but hyperlinks keep white background. > > CentOS 7, Linux 3.10.0-693.5.2.el7.x86_64, X11, Adwaita, GTK 3.22.10. > Can you pls. compare with egit's "empty" page in the repositories view? I would assume that the same issue exists there. (In reply to Thomas Wolf from comment #0) > Created attachment 277577 [details] > Inactive project explorer on empty workspace > > View background turns gray, but hyperlinks keep white background. > > CentOS 7, Linux 3.10.0-693.5.2.el7.x86_64, X11, Adwaita, GTK 3.22.10. > > Eclipse build ID: 4.11.0.I20190212-1800 > > Same behavior in the package explorer. > > Perhaps related: bug 514649. Most likely. (In reply to Thomas Wolf from comment #3) > I clicked on the outline tab. Opened the about dialog later to show the > build ID in the screenshot. on RedHat project explorer stays white when doing that. means, not reproducible there. Simply clicking in the outline tab is not enough. Sorry; I had misremembered. Steps to reproduce: 1. Start Eclipse on an empty workspace 2. Close welcome screen. Resource perspective is shown. 3. Open perspective->Java 4. Switch back to Resource perspective 5. Click on outline tab -> Project explorer gets gray background Same thing with the package explorer in the Java perspective. Add the git repositories view to both, repeat: git repo view consistently keeps the white background. Interestingly: 6. Close Java perspective. 7. Add package explorer to resource perspective, click on outline view -> package explorer keeps the white background! 8. Open Java perspective, click on outline view -> package explorer background turns gray. 9. Subsequently observe package explorer in either perspective to turn gray when inactive. 10. Close Java perspective and package explorer in resource perspective; re-add package explorer to resource perspective: stays white. Sooo... seems to be related to there being two perspectives. Git repositories view in all cases keeps the white background. BTW, the outline view consistently turns gray when inactive, even when there's only one perspective. (In reply to Thomas Wolf from comment #7) > Sooo... seems to be related to there being two perspectives. Git > repositories view in all cases keeps the white background. > > BTW, the outline view consistently turns gray when inactive, even when > there's only one perspective. So what is correct for an "inactive" view? Getting grey or staying white? (In reply to Matthias Becker from comment #8) > (In reply to Thomas Wolf from comment #7) > > Sooo... seems to be related to there being two perspectives. Git > > repositories view in all cases keeps the white background. > > > > BTW, the outline view consistently turns gray when inactive, even when > > there's only one perspective. > > So what is correct for an "inactive" view? Getting grey or staying white? It's note active vs. inactive. It is active vs. inactive view without input. See bug 514649 for details. And "yes", it should stay white. (In reply to Dani Megert from comment #9) > (In reply to Matthias Becker from comment #8) > > (In reply to Thomas Wolf from comment #7) > > > Sooo... seems to be related to there being two perspectives. Git > > > repositories view in all cases keeps the white background. > > > > > > BTW, the outline view consistently turns gray when inactive, even when > > > there's only one perspective. > > > > So what is correct for an "inactive" view? Getting grey or staying white? > It's note active vs. inactive. It is active vs. inactive view without input. > See bug 514649 for details. And "yes", it should stay white. I don't have a linux development machine - only a slow vm. So it's really hard for me to test / fix this. Can somebody of the linux guys take over this? Created attachment 277862 [details]
Inactive Package Explorer on Linux
I can't see the problem with the *Projects* Explorer, but I see the problem with Packages Explorer.
I believe the problem with Packages Explorer is that it looks like it does not define white background color and so re-uses the one from parent, which changes on de-activation.
(In reply to Andrey Loskutov from comment #11) > I believe the problem with Packages Explorer is that it looks like it does > not define white background color and so re-uses the one from parent, which > changes on de-activation. It is worse. It must be in our CSS themes, because if I switch off theming, everything works as expected. So I think this is bug 514649. We should not change *content* background on activation/de-activation. (In reply to Andrey Loskutov from comment #12) > It is worse. It must be in our CSS themes, because if I switch off theming, > everything works as expected. So I think this is bug 514649. I presume so as well. *** This bug has been marked as a duplicate of bug 546673 *** |