Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 544286

Summary: Evaluate if Dialogs#initializeBounds can use asynchronous layouting via requestLayout
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, julian.honnen, Lars.Vogel
Version: 4.11   
Target Milestone: 4.17 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/136528
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d53766b589f0bcb0693c31c4a1da442f9206340e
https://git.eclipse.org/r/136847
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=647370b9c82d726e54289ba22b9af9b9f80a1a01
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166711
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2d19c37c8fe13c6d128fcb64823d79dc18efd07f
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166831
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=454c171e8f6b1022151bc5cedcd02977a94db1a4
Whiteboard:
Bug Depends on: 565473    
Bug Blocks: 563542    

Description Lars Vogel CLA 2019-02-08 08:30:34 EST

    
Comment 1 Eclipse Genie CLA 2019-02-08 08:33:04 EST
New Gerrit change created: https://git.eclipse.org/r/136528
Comment 3 Eclipse Genie CLA 2019-02-13 09:04:50 EST
New Gerrit change created: https://git.eclipse.org/r/136847
Comment 4 Lars Vogel CLA 2019-02-13 09:06:43 EST
Using requestLayout breaks the filter dialog in the Project Explorer. To reproduce open Project Explorer with the change and select "Filter and Customization..." from the view menu.

I'm going to revert the change.
Comment 6 Lars Vogel CLA 2019-02-19 03:31:41 EST
Mass change, please reset target if you still planning to fix this for 4.11.
Comment 7 Dani Megert CLA 2019-05-28 13:06:55 EDT
Lars, please set a new target when you really intend to work on it.
Comment 8 Lars Vogel CLA 2020-06-19 05:26:20 EDT
Julian, in case you are interested, the Project Explorer "Filter and Customization..." would need some additional requestLayout call to work without the gobal layout call.
Comment 9 Julian Honnen CLA 2020-06-19 05:40:08 EDT
(In reply to Lars Vogel from comment #8)
> Julian, in case you are interested, the Project Explorer "Filter and
> Customization..." would need some additional requestLayout call to work
> without the gobal layout call.
I have no time to try it right now, but 
  control.getParent().layout()
should typically replaced with
  control.requestLayout()
Comment 10 Eclipse Genie CLA 2020-07-23 07:59:03 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166711
Comment 12 Lars Vogel CLA 2020-07-24 08:24:10 EDT
Merged. The M3 release cycle should is hopefully sufficient to find potential layout issues with this one.
Comment 13 Eclipse Genie CLA 2020-07-27 05:15:56 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166831
Comment 14 Lars Vogel CLA 2020-07-27 05:19:47 EDT
Will be reverted as Installation details initially not visible To check, select Help -> About -> Installation Details