Bugzilla – Full Text Bug Listing
|
Description
Reto Weiss
Created attachment 277264 [details]
Unzip this to your workspace directory and import the unzipped projects
New Gerrit change created: https://git.eclipse.org/r/135689 I believe the code is old, from 3.x times, so this is not a regression in 4.8? Hi Andrey No it is not a regression. I asume this bug is there since a long time. 4.8 is the version we currently use for our product. Regards It looks like the problem is coming from bug 507795 commit 6fc45bc9c9ccf8c3d1db3213bb423d6e912182df. Gerrit change https://git.eclipse.org/r/135689 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=daf7fb70f33aa29ef831772534496a18291165d6 (In reply to Eclipse Genie from comment #6) > Gerrit change https://git.eclipse.org/r/135689 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/ > ?id=daf7fb70f33aa29ef831772534496a18291165d6 This causes 28 test fails in jdt.ui.tests.refactoring tests in the https://download.eclipse.org/eclipse/downloads/drops4/I20190125-1800/testResults.php build. I'm looking into this. So far it looks like the test issue only. For example org.eclipse.jdt.ui.tests.refactoring.RenameJavaProjectTests.test0 fails to rename project which is referenced by other projects, because it looks like that the .classpath references still point to the old project name. Doing the same in real Eclipse shows no issues, .classpath references of dependent projects are updated properly. (In reply to Andrey Loskutov from comment #7) > (In reply to Eclipse Genie from comment #6) > > Gerrit change https://git.eclipse.org/r/135689 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/ > > ?id=daf7fb70f33aa29ef831772534496a18291165d6 > > This causes 28 test fails in > jdt.ui.tests.refactoring tests in the > https://download.eclipse.org/eclipse/downloads/drops4/I20190125-1800/ > testResults.php build. > > I'm looking into this. Also in the same bucket: org.eclipse.jdt.core.tests.model.JavaSearchMultipleProjectsTests.testHierarchyScope3() Started to fail on I20190125-1800, which can be reproduced also locally. (In reply to Stephan Herrmann from comment #9) > (In reply to Andrey Loskutov from comment #7) > > (In reply to Eclipse Genie from comment #6) > > > Gerrit change https://git.eclipse.org/r/135689 was merged to [master]. > > > Commit: > > > http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/ > > > ?id=daf7fb70f33aa29ef831772534496a18291165d6 > > > > This causes 28 test fails in > > jdt.ui.tests.refactoring tests in the > > https://download.eclipse.org/eclipse/downloads/drops4/I20190125-1800/ > > testResults.php build. > > > > I'm looking into this. > > Also in the same bucket: > org.eclipse.jdt.core.tests.model.JavaSearchMultipleProjectsTests. > testHierarchyScope3() > > Started to fail on I20190125-1800, which can be reproduced also locally. Also here: https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/1612/testReport/org.eclipse.jdt.core.tests.model/JavaSearchMultipleProjectsTests/testHierarchyScope3/ New Gerrit change created: https://git.eclipse.org/r/135807 (In reply to Stephan Herrmann from comment #9) > Also in the same bucket: > org.eclipse.jdt.core.tests.model.JavaSearchMultipleProjectsTests. > testHierarchyScope3() > > Started to fail on I20190125-1800, which can be reproduced also locally. (In reply to Stephan Herrmann from comment #10) > Also here: > https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/1612/testReport/org. > eclipse.jdt.core.tests.model/JavaSearchMultipleProjectsTests/ > testHierarchyScope3/ Sorry for that. We should not let Gerrits to fail for other projects (JDT & JDT UI). (In reply to Eclipse Genie from comment #11) > New Gerrit change created: https://git.eclipse.org/r/135807 I plan to revert the change partly, because we can't revert it fully to avoid decremented bundle version and because I haven't found yet the root cause for test failures and cannot guarantee I will have time to do this soon. @Reto: if you would have time to investigate test failures, it would be great. Gerrit change https://git.eclipse.org/r/135807 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=682eeb2d2dff0189910750b64b3956c25da92ddb Hi Andrey Tests are correct. There is a bug in my implementation of IProject.getReferencingProject(). Will fix this and also add a test for this method. How to proceed? Should I open a new gerrit or change the old one? Regards Reto Please create new gerrit. Thanks Reto. New Gerrit change created: https://git.eclipse.org/r/135901 Gerrit change https://git.eclipse.org/r/135901 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=b8a5b1b3c0a50efb5d7e3e8e14183b530c99105f Thanks Reto! No regressions in https://download.eclipse.org/eclipse/downloads/drops4/I20190206-1800/testResults.php. If you have some time, you could also check bug 543920 and bug 543919 which is on my wish list for fixing soon. Hi Andrey Thanks for your help. I could imagine that bug 543920 and bug 543919 are caused by this bug here. JDT Builder checks if all referenced projects are build before building a project. If a referenced project is not build (e.g. because of a wrong build order) it creates a marker with the text mentioned in those bugs. Then it stops the building of the project. After the referenced projects are build the referencing projects will be build again and the marker is removed. Example: Project B depends on Project A 1. Project B is build. JDT Builder checks if Project A is already build. Since it is not yet build it creates the marker. It returns Project A as dependency to the build system and do not build Project B. 2. Project A is build. 3. Project B is build because it depends on Project A. JDT Builder removes the marker and builds Project B. Regards Reto |