Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 542480

Summary:	Upgrade to SwtBot 2.8
Product:	[Modeling] Sirius	Reporter:	Laurent Redor <laurent.redor>
Component:	Core	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pierre-charles.david
Version:	6.1.1
Target Milestone:	6.1.2
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/133413 https://git.eclipse.org/r/133412 https://git.eclipse.org/r/133498 https://git.eclipse.org/r/127354 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=571e009c9f0f9c7c11437e5957d9de7360a21b87 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=10c64b1362d9bd87b105f73db890f46594853569 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bf90a1f406eb4de22bc9065f290881e4acfe21df https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a1b5c1bd0a51b70fba3c5d7afe63a4cdf4a25ec3 https://git.eclipse.org/r/133687 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e8e63536fea84f9a5cbd5e65bf9aba7e2c46953f
Whiteboard:
Bug Depends on:	537899
Bug Blocks:

Description Laurent Redor

2018-12-06 12:19:28 EST

Some changes, concerning drag'n'drop [1], have been merged in version 2.8 of SwtBot.
This issue consists to migrate to this new version and benefit of the new APIs.
The version used in a first time is not the final version. But a milestone that will be here, at least until the official release (see forum for details [2]).

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=537899
[2] https://www.eclipse.org/forums/index.php/mv/msg/1096393/1799256/#msg_1799256

Comment 1 Eclipse Genie

2018-12-07 04:32:04 EST

Gerrit change https://git.eclipse.org/r/127354 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=571e009c9f0f9c7c11437e5957d9de7360a21b87

Comment 2 Eclipse Genie

2018-12-07 04:32:05 EST

Gerrit change https://git.eclipse.org/r/133498 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=10c64b1362d9bd87b105f73db890f46594853569

Comment 3 Eclipse Genie

2018-12-07 04:32:07 EST

Gerrit change https://git.eclipse.org/r/133412 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bf90a1f406eb4de22bc9065f290881e4acfe21df

Comment 4 Eclipse Genie

2018-12-07 04:32:08 EST

Gerrit change https://git.eclipse.org/r/133413 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a1b5c1bd0a51b70fba3c5d7afe63a4cdf4a25ec3

Comment 5 Eclipse Genie

2018-12-07 09:35:00 EST

New Gerrit change created: https://git.eclipse.org/r/133687

Comment 6 Eclipse Genie

2018-12-07 09:35:42 EST

Gerrit change https://git.eclipse.org/r/133687 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e8e63536fea84f9a5cbd5e65bf9aba7e2c46953f

Comment 7 Pierre-Charles David

2019-01-03 08:17:30 EST

@Laurent, is there something left for this ticket, or can it be closed?

Maybe we should create a separate issue for moving to the final 2.8.0 when it is released, but I have no idea when it is planned, or even if it will have more changes in it that we will need to adapt to.

Comment 8 Pierre-Charles David

2019-01-14 04:54:37 EST

I've created https://bugs.eclipse.org/bugs/show_bug.cgi?id=543406 to remember to switch to the final 2.8.0 when it is available.

Comment 9 Laurent Redor

2019-01-15 02:28:50 EST

(In reply to Pierre-Charles David from comment #7)
> @Laurent, is there something left for this ticket, or can it be closed?
> 
> Maybe we should create a separate issue for moving to the final 2.8.0 when
> it is released, but I have no idea when it is planned, or even if it will
> have more changes in it that we will need to adapt to.

Indeed, all tests expected to be fixed with the version "http://download.eclipse.org/technology/swtbot/milestones/2018-12-m3" of SwtBot are OK now (on all CI servers).
So, as you have already done, this issue could be marked as "Resolved".

Comment 10 Laurent Redor

2019-01-15 02:30:22 EST

There is no specific steps to validate. It was already done by verifying impacted tests (see commits for details) on all CI servers.

Comment 11 Pierre-Charles David

2019-02-15 09:02:05 EST

Available in Sirius 6.1.2, see https://wiki.eclipse.org/Sirius/6.1.2 for details.