Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 541832

Summary:	[code mining] Update preferences text to indicate references include implementations
Product:	[Eclipse Project] JDT	Reporter:	Noopur Gupta <noopur_gupta>
Component:	UI	Assignee:	Noopur Gupta <noopur_gupta>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	azerr, daniel_megert, sarika.sinha
Version:	4.10	Flags:	sarika.sinha: review+
Target Milestone:	4.10 RC2
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=541395 https://git.eclipse.org/r/133383 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7f8eedd485207fa7c633e5550cf9178d17586438 https://git.eclipse.org/r/133385 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=81828bcc0c34d7122fb1ba9d51b09c2a119dc4cd https://git.eclipse.org/r/133386 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=927b048ec6e0a030a3fe03b8392a2a8ec15b86b2
Whiteboard:
Bug Depends on:	529127
Bug Blocks:

Description Noopur Gupta

2018-12-03 05:47:31 EST

The references include the implementations also which should be made clear to the user. Otherwise, it may be confusing to see "1 reference | 1 implementation" which open the same location.

Hence, update the preferences text to:
Show references (including implementations) for

Comment 1 Eclipse Genie

2018-12-03 06:06:15 EST

New Gerrit change created: https://git.eclipse.org/r/133383

Comment 2 Eclipse Genie

2018-12-03 06:06:27 EST

Gerrit change https://git.eclipse.org/r/133383 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7f8eedd485207fa7c633e5550cf9178d17586438

Comment 3 Sarika Sinha

2018-12-03 06:09:15 EST

Looks good for RC2.

Comment 4 Eclipse Genie

2018-12-03 06:28:41 EST

New Gerrit change created: https://git.eclipse.org/r/133385

Comment 5 Eclipse Genie

2018-12-03 06:33:54 EST

Gerrit change https://git.eclipse.org/r/133385 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=81828bcc0c34d7122fb1ba9d51b09c2a119dc4cd

Comment 6 Eclipse Genie

2018-12-03 06:40:08 EST

New Gerrit change created: https://git.eclipse.org/r/133386

Comment 7 Eclipse Genie

2018-12-03 06:43:21 EST

Gerrit change https://git.eclipse.org/r/133386 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=927b048ec6e0a030a3fe03b8392a2a8ec15b86b2

Comment 8 Noopur Gupta

2018-12-03 06:44:15 EST

F1 help doc and N&N entry have been updated.

Comment 9 Noopur Gupta

2018-12-06 05:08:34 EST

Verified as fixed in I20181204-0600.