Bugzilla – Full Text Bug Listing
| Summary: | [Gtk3] Regression: TableColumn.pack() clears header in 4.9 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Patrick Tasse <patrick.tasse> | ||||||||
| Component: | SWT | Assignee: | Xi Yan <xixiyan> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | akurtakov, ericwill, loskutov | ||||||||
| Version: | 4.9 | Flags: | akurtakov:
review+
|
||||||||
| Target Milestone: | 4.10 RC2 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| See Also: |
https://git.eclipse.org/r/133315 https://bugs.eclipse.org/bugs/show_bug.cgi?id=532941 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=59b0f429a75003d153116d1b4753427591e69bad |
||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 276770 [details]
After packing one column
Created attachment 276771 [details]
After packing all columns
New Gerrit change created: https://git.eclipse.org/r/133315 Regression from bug 532941. I wonder if we can have a test which pack() the column twice and checks afterwards if it is still visible? Eric, can you please check the patch? I believe it should be OK for 4.10 RC2? Thanks Xi, I tested your patch and it fixes the issue for me on gtk3.10.8. Gerrit change https://git.eclipse.org/r/133315 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=59b0f429a75003d153116d1b4753427591e69bad Alex, it is a bit too late, but this got merged after RC1. We need approval I guess. Approved. Please veirfy with latest I-build. Xi, Patrick, please verify with latest SDK build. Tested in I20181203-0600 with gtk 3.10.8. Verified in I20181203-0600 with GTK3.24.1. |
Created attachment 276769 [details] Snippet In 4.9, calling TableColumn.pack() clears the column header. If all columns have their header cleared in this way, the header height is zeroed and the table header is no longer visible. Packing the column from the OS (by double-clicking on the column header split) does not trigger the same problem. The problem does not occur in 4.8. Reproduced with gtk 3.10.8 and gtk 3.20.8. Including a code snippet, double-clicking on a cell packs its column.