Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 541434

Summary: Investigate validation for Java 10 and beyond in LaunchValidationOperation
Product: [Eclipse Project] PDE Reporter: Vikas Chandra <Vikas.Chandra>
Component: UIAssignee: Vikas Chandra <Vikas.Chandra>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, julian.honnen, Lars.Vogel
Version: 4.10   
Target Milestone: 4.11 M3   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/132898
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0a0e44733a94e46826345c7d6be8f75afd4b871a
Whiteboard:

Description Vikas Chandra CLA 2018-11-22 03:23:20 EST 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=541307#c15

It must be investigated why this validation is done and if we can just do away with this going forward.

Also this has be to kept, use Use try-with-resources as suggested by Lars here
https://git.eclipse.org/r/#/c/132809/
Comment 1 Lars Vogel CLA 2018-11-22 03:27:15 EST 
Julian, could you provide a fix for the try-with-resources part?
Comment 2 Eclipse Genie CLA 2018-11-22 09:16:52 EST 
New Gerrit change created: https://git.eclipse.org/r/132898
Comment 4 Lars Vogel CLA 2018-12-13 04:50:19 EST 
(In reply to Vikas Chandra from comment #0)

> It must be investigated why this validation is done and if we can just do
> away with this going forward.

Who is doing this investigation?
Comment 5 Lars Vogel CLA 2019-01-08 10:41:53 EST 
(In reply to Lars Vogel from comment #4)
> (In reply to Vikas Chandra from comment #0)
> 
> > It must be investigated why this validation is done and if we can just do
> > away with this going forward.
> 
> Who is doing this investigation?

Alex, could you have a look at this before the old problem slips our mind? Alternatively we can also mark this bug as fixed with the try-with-resource change.
Comment 6 Vikas Chandra CLA 2019-01-09 00:40:54 EST 
Putting this in M3 milestone so that it gets more attention.
Comment 7 Vikas Chandra CLA 2019-01-09 05:01:21 EST 
I looked at multiple comments and now I recall the issue.
Post java 10, we have a different way to retrieve system packages from JRE.

I think the current workaround should work fine for java 12 and later too and no further modification of code is required.

BundleValidationOperation set platform properties to the OSGI state. I think this should be continued. 
fState.setPlatformProperties(fProperties);

I am not sure what things would be affected if this is removed ( for later java 12 or later).
Comment 8 Vikas Chandra CLA 2019-02-11 05:00:31 EST 
See comment#7

Fixed with https://bugs.eclipse.org/bugs/show_bug.cgi?id=541307#c13
Comment 9 Vikas Chandra CLA 2019-02-15 04:49:41 EST 
Can bug reporter or bug assignee please verify this defect for 4.11M3?
Comment 10 Lars Vogel CLA 2019-02-15 04:53:05 EST 
(In reply to Vikas Chandra from comment #9)
> Can bug reporter or bug assignee please verify this defect for 4.11M3?

Bug assignee is you. :-)
Comment 11 Vikas Chandra CLA 2019-02-15 05:03:03 EST 
>>Bug assignee is you. :-)

I wrote a common comment for all unverified bugs. We have time till next week tuesday :)