Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 541416

Summary:	[code mining] Missing code minings in class file editor
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	Text	Assignee:	Mickael Istria <mistria>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	azerr, mistria, noopur_gupta
Version:	4.10	Flags:	noopur_gupta: review+
Target Milestone:	4.10 RC1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/132865 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=fdd100a2139acb793609532f6fbaa19938acf219
Whiteboard:
Bug Depends on:	529127
Bug Blocks:

Description Dani Megert

2018-11-21 10:53:26 EST

Missing code minings in class file editor.

Comment 1 Eclipse Genie

2018-11-21 17:17:56 EST

New Gerrit change created: https://git.eclipse.org/r/132865

Comment 2 Eclipse Genie

2018-11-22 11:52:37 EST

Gerrit change https://git.eclipse.org/r/132865 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=fdd100a2139acb793609532f6fbaa19938acf219

Comment 3 Dani Megert

2018-11-22 11:53:27 EST

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/132865

This fixes
> No code minings when opening .class editor 


The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.

Comment 4 Angelo ZERR

2018-11-22 12:02:58 EST

> The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.

Even if I understand that it appears as a bug, I'm a little afraid with performance if we add this binary search. I'm afraid that codemining will become less responsive.

Comment 5 Noopur Gupta

2018-11-23 01:10:52 EST

(In reply to Dani Megert from comment #3)
> The major problem is still that binary references aren't shown. This might
> also be an issue with source files. We can use this bug or open a new one.
I have opened bug 541479 for the binary reference count problem.

Comment 6 Dani Megert

2018-11-23 04:05:44 EST

(In reply to Angelo ZERR from comment #4)
> > The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.
> 
> Even if I understand that it appears as a bug, I'm a little afraid with
> performance if we add this binary search. I'm afraid that codemining will
> become less responsive.

Please comment in bug 541479.

Comment 7 Noopur Gupta

2018-11-29 04:18:17 EST

Verified as fixed in I20181128-1800.