Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 541412

Summary: [drag and drop] DND fails when dropping a bordered node on a shadowed container
Product: [Modeling] Sirius Reporter: Laurent Fasani <laurent.fasani>
Component: DiagramAssignee: Laurent Fasani <laurent.fasani>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 5.1.3   
Target Milestone: 5.1.4   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/132790
https://git.eclipse.org/r/132909
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=39dc07ca4bc8445709251119ab600ff3e0ef2cd3
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=40a837a74d6f18347601884c655c62d9ce649627
Whiteboard:
Bug Depends on:    
Bug Blocks: 541442    
Attachments:
Description Flags
project to reproduce
none
project to reproduce none

Description Laurent Fasani CLA 2018-11-21 10:40:58 EST
Created attachment 276646 [details]
project to reproduce

Steps to reproduce
* open the attached project and the diagram
* select the IN bordered node from E1 node and drag it onto the shadow of the bottom of E1 node
-> the source feedback(border node) appears whereas the target feedback (E3 node) don't
* drop the bordered element(releasing the left button) 
-> the bordered node is not moved on the feedback area but stays on E1
Comment 1 Laurent Fasani CLA 2018-11-22 05:33:04 EST
Steps to validate
* open the the diagram in the  attached project
* select the IN bordered node from E3 node and drag it onto the shadow of the bottom of E1 node
->there should be no feedback
* drop the bordered element(releasing the left button) 
-> the IN bordered node remains on E3
Comment 2 Laurent Fasani CLA 2018-11-23 04:12:46 EST
Added 
https://git.eclipse.org/r/#/c/132790/
Comment 3 Laurent Fasani CLA 2018-11-23 04:14:56 EST
A new bug is linked to the bordered node drag and
When dropping the boredered node from a node to its parent container node, and if zoom is activated, the bordered node source feedback is bad sized and located.

Added to fix it : https://git.eclipse.org/r/#/c/132909/
Comment 4 Laurent Fasani CLA 2018-11-23 04:20:22 EST
STEPS TO VALIDATE:

Do the Comment 1 scenario

Additional scenario:
* open the the diagram in the  attached project
* select the IN bordered node from E3 (or E1)  node and drag it onto the shadow of the bottom of P0 container
-> there should be no feedback
* move the mouse slightly upward so that the bordered node feeback is displayed
-> the feedback should be located under the mouse and with the same size as the boredered node itself(no unexpected zoom of the node)
Comment 6 Laurent Fasani CLA 2018-11-23 11:24:41 EST
Created attachment 276678 [details]
project to reproduce
Comment 8 Laurent Fasani CLA 2018-12-06 05:32:01 EST
validated with T4C1.2.2
Comment 9 Pierre-Charles David CLA 2019-01-24 04:54:22 EST
Available in Sirius 5.1.4, see https://wiki.eclipse.org/Sirius/5.1.4 for details.