Bugzilla – Full Text Bug Listing
| Summary: | [code mining] implementations not shown on class | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Noopur Gupta <noopur_gupta> |
| Component: | UI | Assignee: | Jeff Johnston <jjohnstn> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, jjohnstn, Lars.Vogel, mistria, noopur_gupta, rgrunber, sarika.sinha |
| Version: | 4.10 | Flags: | Lars.Vogel:
pmc_approved+
noopur_gupta: review+ |
| Target Milestone: | 4.10 RC2 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/132997 https://bugs.eclipse.org/bugs/show_bug.cgi?id=541832 https://bugs.eclipse.org/bugs/show_bug.cgi?id=541834 |
||
| Whiteboard: | |||
| Bug Depends on: | 529127 | ||
| Bug Blocks: | |||
Angelo, it will be good to fix this for RC1. Implementations are also missing on the methods. Resetting assignee to clarify someone else can work on this at the moment. New Gerrit change created: https://git.eclipse.org/r/132997 (In reply to Noopur Gupta from comment #0) > I20181120-1800 > > package a; > public class A { > } > > package a; > public class B extends A { > } > > => class A should show "1 implementation" as its annotation but it is not > shown. I have fixed the class issue with the above gerrit patch. It also adds the find action to the implementation message so clicking shows type hierarchy. (In reply to Jeff Johnston from comment #5) > I have fixed the class issue with the above gerrit patch. Please add the fix for methods also in the patch. > It also adds the > find action to the implementation message so clicking shows type hierarchy. With your patch, I see that Search view is opened to show the implementors. See bug 541390 where we want to open the Type Hierarchy view on clicking the "implementations" annotation. It will be good to attach this part of the fix to bug 541390 so that further discussion can happen on the dedicated bug. New Gerrit change created: https://git.eclipse.org/r/133279 Jeff, I have released the part of your patch to show "implementations" annotation on classes: https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=04983d9cfd4995e38ef96821aa98e4ec6e6c6307 For enabling the "implementations" annotation on methods and handling the clickable behavior, we will continue the discussion from your patch here. Copying your comment from Gerrit regarding this: For method implementors, this patch opens the Search View corresponding to a search->declarations->hierarchy. Dani, do you suggest going with the implementation in the patch for methods? Also, if we add the "implementations" annotation on methods, we can also add the preferences for this i.e. - Show implementations for - Types - Methods Probably something for 4.11. (In reply to Noopur Gupta from comment #8) > Jeff, I have released the part of your patch to show "implementations" > annotation on classes: > https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=04983d9cfd4995e38ef96821aa98e4ec6e6c6307 I have given +2 for this on the Gerrit patch. (In reply to Noopur Gupta from comment #8) > For enabling the "implementations" annotation on methods and handling the > clickable behavior, we will continue the discussion from your patch here. > Copying your comment from Gerrit regarding this: > > For method implementors, this patch opens the Search View corresponding to a > search->declarations->hierarchy. > > Dani, do you suggest going with the implementation in the patch for methods? > > Also, if we add the "implementations" annotation on methods, we can also add > the preferences for this i.e. > - Show implementations for > - Types > - Methods > Probably something for 4.11. We had a discussion in the team and decided to move the methods story to 4.11 as it needs more thinking. I have opened bug 541834 for this. Jeff, please attach your existing patch to the new bug. Also, we discussed and decided to modify the preferences text as per bug 541832. This bug is about the missing implementations annotation on classes for which the fix has been released as mentioned in comment #9. Verified as fixed in I20181204-0600. |
I20181120-1800 package a; public class A { } package a; public class B extends A { } => class A should show "1 implementation" as its annotation but it is not shown.