Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 541065

Summary:	Adopt ASM 7 jars from Orbit for 4.10
Product:	[Eclipse Project] Platform	Reporter:	Sarika Sinha <sarika.sinha>
Component:	Releng	Assignee:	Sarika Sinha <sarika.sinha>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, Vikas.Chandra
Version:	4.10
Target Milestone:	4.10 M3
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/132324 https://git.eclipse.org/r/132344 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=fa43cba6bf10400b0babd78873a407acb7389f40 https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=d56213af830836ca40bad75a65d306c322845f81 https://git.eclipse.org/r/132396 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=98b88b66c26511064ec4153ab93d9148adeb92f5 https://git.eclipse.org/r/132413
Whiteboard:
Bug Depends on:
Bug Blocks:	540570

Description Sarika Sinha

2018-11-13 03:45:31 EST

ASM 7 Jars should be adopted for 4.10

Bug 540536 added the ASM 7 jars to Orbit

Comment 1 Eclipse Genie

2018-11-13 04:12:53 EST

New Gerrit change created: https://git.eclipse.org/r/132324

Comment 2 Alexander Kurtakov

2018-11-13 04:19:39 EST

Sarika, are there other changes needed elsewhere or this one can be delivered at any time and build will not break ?

Comment 3 Sarika Sinha

2018-11-13 04:54:12 EST

(In reply to Alexander Kurtakov from comment #2)
> Sarika, are there other changes needed elsewhere or this one can be
> delivered at any time and build will not break ?

It can break in PDE and JDT, we will bump the range.

Also we will see if the gerrit build goes through fine.

Comment 4 Sarika Sinha

2018-11-13 06:10:37 EST

Vikas will provide the PDE patch, JDT should not break the build.

Comment 5 Eclipse Genie

2018-11-13 08:57:31 EST

New Gerrit change created: https://git.eclipse.org/r/132344

Comment 6 Eclipse Genie

2018-11-14 00:38:06 EST

Gerrit change https://git.eclipse.org/r/132344 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=fa43cba6bf10400b0babd78873a407acb7389f40

Comment 7 Eclipse Genie

2018-11-14 00:47:19 EST

Gerrit change https://git.eclipse.org/r/132324 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=d56213af830836ca40bad75a65d306c322845f81

Comment 8 Eclipse Genie

2018-11-14 03:35:36 EST

New Gerrit change created: https://git.eclipse.org/r/132396

Comment 9 Eclipse Genie

2018-11-14 03:36:18 EST

Gerrit change https://git.eclipse.org/r/132396 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=98b88b66c26511064ec4153ab93d9148adeb92f5

Comment 10 Vikas Chandra

2018-11-14 03:42:24 EST

The last commit should ensure that the build is fine. Full rollback and change to ASM7 will be done via bug 541136. That should be done by I20181114-1800

Comment 11 Eclipse Genie

2018-11-14 05:33:42 EST

New Gerrit change created: https://git.eclipse.org/r/132413

Comment 12 Sarika Sinha

2018-11-16 02:05:41 EST

Nothing more to be done as part of this bug.