Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 540779

Summary:	[code mining] Log error only if needed
Product:	[Eclipse Project] Platform	Reporter:	Angelo ZERR <azerr>
Component:	Text	Assignee:	Angelo ZERR <azerr>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	Lars.Vogel, mistria, tobias.melcher
Version:	4.8
Target Milestone:	4.10 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/131920 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6a5ee7545b2018fece5e4b4ee8b2d1879c7275c5
Whiteboard:
Bug Depends on:
Bug Blocks:	529127

Description Angelo ZERR

2018-11-05 03:58:56 EST

Since error was logged in https://bugs.eclipse.org/bugs/show_bug.cgi?id=539317 we can have a lot of error log with "CancellationException " See https://github.com/angelozerr/jdt-codemining/issues/83

To fix this issue, we should ignore CancellationException. 

There is too a problem when CodeMining is used in Java main (CodeMiningDemo), because the org.eclipse.jface.text bundle doesn't exists.

A patch will follow to fix those 2 problems.

Comment 1 Eclipse Genie

2018-11-05 04:02:44 EST

New Gerrit change created: https://git.eclipse.org/r/131920

Comment 2 Angelo ZERR

2018-11-05 04:03:50 EST

Guys please review my gerrit patch at https://git.eclipse.org/r/#/c/131920/

I think this issue is annoying for error log explained at https://github.com/angelozerr/jdt-codemining/issues/83

Comment 3 Eclipse Genie

2018-11-08 08:29:51 EST

Gerrit change https://git.eclipse.org/r/131920 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6a5ee7545b2018fece5e4b4ee8b2d1879c7275c5

Comment 4 Mickael Istria

2018-11-08 08:30:14 EST

Thanks Angelo!

Comment 5 Angelo ZERR

2018-11-08 08:44:57 EST

Thank's  @Mickael for your review!