Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 540597

Summary:	DOT Graph View - Cannot copy NPE diagnosis.
Product:	[Tools] GEF	Reporter:	Ed Willink <ed>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	miklossy
Version:	unspecified
Target Milestone:	5.0.300 (2018-12)
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Ed Willink

2018-10-30 05:35:29 EDT

Bug 540596 provides a repro that gives an NPE popup dialog.

The detailed text in the popup dialog containing the NPE and graph cannot be copied into paste them to a Bugzilla.

Why does Ctrl-A work but Ctrl-C not?

Comment 1 Tamas Miklossy

2018-11-01 08:05:53 EDT

Hello Ed!

Thanks for your bug report! I pushed the following changes to the master branch:

[540597] Improve Error Dialog in case the DOT file cannot be imported.

- Use the org.eclipse.ui.statushandlers.StatusManager to display the
error message to the user in case the DOT file cannot be imported. With
this change, the error diagnostic can be copied to the clipboard via the
keyboard shortcut CTRL+C.

Could you please give it a try with the latest build and confirm that the Error Dialog works as desired?

Comment 2 Ed Willink

2018-11-01 08:26:28 EDT

Ctrl-C not working in dialogs/views has been a regular irritant for me, with some of my reports coming back with WORKSFORME. I was lightly hoping this one was solid and you might forward to SWT for the general fix. Your fix suggests that every bad Dialog must be fixed by an individual Bugzilla report. Shouldn't whatever base Dialog you were using be fixed instead?

(I'm sure your fix will work, but without a fix for the underlying NPE GEF's DOT View is not helpful to me. Indeed I have suspicions that it aggravates EClipse's usual sluggishness.)

Comment 3 Tamas Miklossy

2018-11-30 08:46:58 EST

I resolve this as fixed in 5.0.300 (2018-12).