Bugzilla – Full Text Bug Listing
| Summary: | Replace default class file editor by Bytecode outline | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Mickael Istria <mistria> |
| Component: | Text | Assignee: | JDT-Text-Inbox <jdt-text-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | daniel_megert, karsten.thoms, loskutov, sw |
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=540546 | ||
| Whiteboard: | |||
|
Description
Mickael Istria
I was asked by Stephan WDYT about contributing my Bytecode outline view to JDT. https://marketplace.eclipse.org/content/bytecode-outline I think this would be great. We can discuss here or on a different bug if there is interest. (In reply to Andrey Loskutov from comment #1) > I was asked by Stephan WDYT about contributing my Bytecode outline view to > JDT. Cool! > We can discuss here or on a different bug if there is interest. I think here is fine. At leasr, as the reporter, I'm ok with using this ticket to track contribution of bytecode outline. I've checked the git, the project was licensed under BSD (this was ASM license at that days), so I've asked two other contributors about switching to EPL, see https://gitlab.ow2.org/asm/eclipse-plugin/issues/317558. So it depends on their agreement. Until this has been decided, can we use https://git.eclipse.org/r/#/c/131570/ ? An update: All main contributors (Eric Bruneton, Eugene Kuleshove and me) are agreed to move the code to the EPL 2.0 (see https://gitlab.ow2.org/asm/eclipse-plugin/issues/317558). IP cleanup: there were few code snippets coming from other guys, so I've removed all this code contributed by them and also rewrote the Bytecode Reference view to NOT use Java specs we had from O'Reily (we had permissions to redisthribute for the old plugin, but who knows...), so we use now publicly available JVM specs (fetching them on demand from internet). So we should be IP clean now from my POV. While doing this I've updated plugin to use ASM 7 so now it supports Java 11 bytecode. Finally I've moved the packages from de.loskutov to org.eclipse.jdt.bcoview namespace (final name to be discussed). This state is now hosted under: https://github.com/iloveeclipse/bytecodeoutline/ the plugin is published under this update site (as before) http://andrei.gmxhome.de/eclipse the zipped offline update site can be found at: https://github.com/iloveeclipse/bytecodeoutline/releases/tag/1.0.0_alpha TODOs: 1) The ID I've chosen for the view is org.eclipse.jdt.bcoview. This can be discussed of coarse, I've just followed what I saw in JDT UI repo: org.eclipse.jdt.astview, org.eclipse.jdt.jeview. BCO stands for ByteCodeOutline, original plugin name. 2) I had no time to "mavenize" the build and to move few existing tests to the dedicated bundle. Currently build is ant based and tests are included. 3) I've also fully removed the old bytecode editor which need to be re-written anyway in close collaboration with jdt.ui. I have no idea when I will have time for the points above, so it may not fit into 4.11 timeframe. If anyone has time, feel free to contribute via github. (In reply to Mickael Istria from comment #0) > When reading a .class file, we get always the same font and colors. Using > some syntax highlighting to highlight keywords or identifier (same > highlighting as Java editor) would make those files easier to read in the > viewer. I'm sorry but I don't understand what you are actually asking for. For sure we won't replace showing the attached source when opening a class file. What we do when there's no source is a different question. Currently we use ClassFileBytesDisassembler. There are no plans to work on this. (In reply to Dani Megert from comment #7) > There are no plans to work on this. If someone is interested, follow up task is https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/364 |