Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 540331

Summary: DOT Editor - Improve Quickfixing of invalid multiple style attribute value
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.1.0 (2019-06)   
Hardware: PC   
OS: Windows 10   
Whiteboard: low-hanging fruit
Attachments:
Description Flags
screencast reproducing the bug none

Description Tamas Miklossy CLA 2018-10-20 04:10:56 EDT
Created attachment 276320 [details]
screencast reproducing the bug

Given is the following DOT graph with invalid multiple style attribute value:

graph {
    1--2[style="foo, bold"]
}

Currently, the DOT Editor offers quickfixes to replace the invalid foo value with a valid one. However, the quickfix also removes the other style item. See also screencast.gif in attachment.

The quickfix implementation should only replace the invalid style with a valid one leaving the other valid style items untouched.
Comment 1 Tamas Miklossy CLA 2019-02-09 08:39:38 EST
I pushed the following changes to the master branch:

[513196] Improve the DOT Editor Quickfix support.

Modify the DotQuicfixProvider to provide qickfixes for;
- invalid multiple arrowhead/arrowtail attribute values
- invalid multiple arrowtail attribute values
- invalid multiple style attribute values
- redundant multiple style attribute values
- deprecated style attribute values

Implement corresponding DotQuickfixTests test cases.
Comment 2 Tamas Miklossy CLA 2019-03-16 03:30:12 EDT
I resolve this issue as fixed in 5.1.0 (2019-06).