| Summary: | DOT Editor - Implement redundant style item validation rule and corresponding quickfix | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Tamas Miklossy <miklossy> |
| Component: | GEF DOT | Assignee: | gef-inbox <gef-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | 5.1.0 (2019-06) | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
| Whiteboard: | low-hanging fruit | ||
I pushed the following changes to the master branch: [540329] Add checkDuplicatedStyleItem to the DotStyleJavaValidator. - Implement Dot Style validation rule to verify if a style item is defined more than once. - Implement corresponding DotValidatorTests test cases. I pushed the following changes to the master branch: [513196] Improve the DOT Editor Quickfix support. Modify the DotQuicfixProvider to provide qickfixes for; - invalid multiple arrowhead/arrowtail attribute values - invalid multiple arrowtail attribute values - invalid multiple style attribute values - redundant multiple style attribute values - deprecated style attribute values Implement corresponding DotQuickfixTests test cases. I resolve this issue as fixed in 5.1.0 (2019-06). |
Given is the following DOT graph with redundant style items: graph { 1[style="bold, bold"] 1--2 [style="dashed, dashed"] } The DOT Editor should recognize if a style item is defined more than once and issue corresponding warnings. Quickfixes should be also provided to remove the redundant style item.