Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 539937

Summary:	Performance tests are missing for JDT core
Product:	[Eclipse Project] JDT	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Core	Assignee:	JDT-Core-Inbox <jdt-core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, Lars.Vogel, manoj.palat, sravankumarl, stephan.herrmann
Version:	4.7
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/130658 https://git.eclipse.org/r/130659
Whiteboard:

Description Lars Vogel

2018-10-08 18:09:34 EDT

If I look at the performance test results of our builds, they are missing for JDT core.

See for example http://download.eclipse.org/eclipse/downloads/drops4/I20181006-1800/performance/org.eclipse.jdt.core.php?fp_type=0

It looks to me that the org.eclipse.jdt.core.tests.binaries contain a very old reference platform (3.0) which contains a lot of Eclipse 2.0 plug-ins and as we removed the 2.0 support this fails to load.

I suggest updating the target platform. If I do this I can run the test locally.

Comment 1 Lars Vogel

2018-10-08 18:14:50 EDT

Sravan/Alex, can you tell me how works on the performance tests?

Comment 2 Eclipse Genie

2018-10-08 18:18:23 EDT

New Gerrit change created: https://git.eclipse.org/r/130658

Comment 3 Eclipse Genie

2018-10-08 18:19:36 EDT

New Gerrit change created: https://git.eclipse.org/r/130659

Comment 4 Lars Vogel

2018-10-08 18:22:58 EDT

With these two changes I can execute the performance tests locally (at least the once I tried, they run a very long time so I ran most of them one after the other).

Can someone have a look and tell me if the change is OK? If yes, I will cleanup the zip file by deleting the .class files in the zip.

Comment 5 Lars Vogel

2018-10-09 02:03:56 EDT

So far two tests are failing:

testDomAstCreationProjectJLS3
testFullBuildDefault

-> I think testDomAstCreationProjectJLS3 can be removed as we do not have JLS3 projects anymore.

Not sure what to do with testFullBuildDefault.

Comment 6 Stephan Herrmann

2018-10-09 05:50:58 EDT

(In reply to Lars Vogel from comment #5)
> So far two tests are failing:
> 
> testDomAstCreationProjectJLS3
> testFullBuildDefault
> 
> -> I think testDomAstCreationProjectJLS3 can be removed as we do not have
> JLS3 projects anymore.

If you want to remove a test as being obsolete, please indicate by which other (remaining) test it is superseded. If there is no such newer test, then updating the old test would be better than removing

Comment 7 Lars Vogel

2018-10-09 10:54:53 EDT

(In reply to Stephan Herrmann from comment #6)
> (In reply to Lars Vogel from comment #5)
> > So far two tests are failing:
> > 
> > testDomAstCreationProjectJLS3
> > testFullBuildDefault

> If you want to remove a test as being obsolete, please indicate by which
> other (remaining) test it is superseded. If there is no such newer test,
> then updating the old test would be better than removing

I will restore the test and set them to inactive. This way we can enable the rest of the test, AFAICS currently none are running.

Comment 8 Manoj N Palat

2019-02-11 03:57:03 EST

Bulk move out of 4.11

Comment 9 Lars Vogel

2020-01-20 04:05:41 EST

Sravan, looks like this one was fixed somewhere else. I see JDT core results.
 https://download.eclipse.org/eclipse/downloads/drops4/I20200118-1800/performance/org.eclipse.jdt.core.php?fp_type=0