Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 539569

Summary:

[Sequence Diagram] Tool to insert vertical blank space is KO with zoom

Product:

[Modeling] Sirius

Reporter:

Laurent Redor <laurent.redor>

Component:

Diagram

Assignee:

Laurent Redor <laurent.redor>

Status:

CLOSED FIXED

QA Contact:

Severity:

major

Priority:

CC:

julien.dupont

Version:

unspecified

Target Milestone:

6.1.0

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/130085
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c793dd0051652f6d5f95cebdd4bb362838d6fa21
https://bugs.eclipse.org/bugs/show_bug.cgi?id=538298

Whiteboard:

need_test

Attachments:

Description	Flags
Interaction.zip	none

Description Laurent Redor

2018-09-27 11:05:15 EDT

Since bug 529790, creation of this new feature, there is a problem with zoom.

When inserting space from the ruler, the feedback is OK but the space is not inserted at the correct location.
When inserting space directly from the diagram, the feedback is KO and he space is not inserted at the correct location.

Comment 1 Laurent Redor

2018-09-27 11:15:02 EDT

Created attachment 276027 [details]
Interaction.zip

Steps to reproduce:
* Import project "Interaction" (from Interaction.zip)
* Open the diagram "Sequence Diagram on My"
* Display the ruler
* Set the units to Pixels
* From the ruler, add 50 pixels from 150 to 200 (by drag'n'drop in the ruler with CTRL key press)
* Expected1: Feedback is displayed at the right location during drag'n'drop --> OK
* Expected2 : 50 pixels is added between the header of lifeline and the message m1 --> OK
* Undo
* From the diagram, add 50 pixels from 150 to 200 (by drag'n'drop in the diagram with CTRL+SHIFT key press)
* Expected1: Feedback is displayed at the right location during drag'n'drop --> OK
* Expected2: 50 pixels is added between the header of lifeline and the message m1 --> OK
* Undo
* Set the zoom to 200%
* From the ruler, add 50 pixels from 150 to 200 (by drag'n'drop in the ruler with CTRL key press)
* Expected1: Feedback is displayed at the right location during drag'n'drop --> OK
* Expected2 : 50 pixels is added between the header of lifeline and the message m1 --> KO
* Undo
* From the diagram, add 50 pixels from 150 to 200 (by drag'n'drop in the diagram with CTRL+SHIFT key press)
* Expected1: Feedback is displayed at the right location during drag'n'drop --> KO
* Expected2: 50 pixels is added between the header of lifeline and the message m1 --> KO
* Undo

Comment 2 Laurent Redor

2018-09-27 11:36:51 EDT

(In reply to Laurent Redor from comment #0)
> Since bug 529790, creation of this new feature, there is a problem with zoom.
> 
This is wrong. It is only since bug 538298 that this problem appears.

Comment 3 Eclipse Genie

2018-09-27 12:49:25 EDT

New Gerrit change created: https://git.eclipse.org/r/130085

Comment 4 Eclipse Genie

2018-09-28 02:29:20 EDT

Gerrit change https://git.eclipse.org/r/130085 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c793dd0051652f6d5f95cebdd4bb362838d6fa21

Comment 5 Laurent Redor

2018-09-28 02:31:24 EDT

This issue is marked as resolved but an automatic test should be added.

Comment 6 Pierre-Charles David

2018-10-19 12:48:09 EDT

Available in Sirius 6.1.0, see https://wiki.eclipse.org/Sirius/6.1.0