Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 539365

Summary: Comment field missing after fix to bug 536678
Product: Community Reporter: Tony Weddle <tony>
Component: MarketplaceAssignee: Marketplace Inbox <marketplace-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: chris.guindon, eric.poirier, webmaster
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
MP Comment form with missing text box none

Description Tony Weddle CLA 2018-09-24 05:46:29 EDT
Following the application of a fix to bug 536678, it's impossible to add new reviews or add comments to existing reviews, since the text field for the required Comments field is missing, showing just a blank space that cannot be typed into.

I've tried this on Firefox and Chrome, running under Windows 10.
Comment 1 Eric Poirier CLA 2018-09-24 08:52:27 EDT
Hi Tony,

Can you provide the error message you're getting as well as the name of the field you cannot type into?

I tested this quickly in Chrome on a mac and I was able to reply to a comment successfully but the error you're having is related to something else.

Thanks.
Comment 2 Tony Weddle CLA 2018-09-25 04:43:33 EDT
Created attachment 275960 [details]
MP Comment form with missing text box

Sorry, the field name is "Comment" not Comments, as I originally stated. I've attached a screenshot of what I see (I just tried this on Windows 10/Firefox and Ubuntu 16.04/Firefox), previously tried with Chrome on Windows 10. Haven't checked a Mac yet, but see the problem on all of those other combinations.

No error message, but if I just hit Save, of course, I would get an error message that a the "Comment field is required".
Comment 3 Tony Weddle CLA 2018-09-26 00:30:13 EDT
I'm not sure how Eric got this to work on Mac and Chrome. I just tried both Safari and Chrome on a Mac (High Sierra) but had the same problem as before: the Comment field text box simply isn't there to enter text into.
Comment 4 Tony Weddle CLA 2018-09-26 00:45:30 EDT
I don't know why I didn't think of this before but, after clicking the "Switch to plain text editor" link, I do get a text box that works. The problem is with the rich text editor. I can live with that until this is fixed.
Comment 5 Christopher Guindon CLA 2018-09-26 11:38:40 EDT
Raising the priority.
Comment 6 Eric Poirier CLA 2018-09-26 13:26:18 EDT
I disabled the option to "Aggregate Javascript files" and Authenticated users can now use the Comment field again.

The JS error I was getting was the following:

Refused to execute script from 'https://marketplace.eclipse.org/sites/all/modules/contrib/ckeditor/ckeditor.config.js?&t=G2VC' because its MIME type ('text/x-js') is not executable, and strict MIME type checking is enabled.

Refused to execute script from 'https://marketplace.eclipse.org/sites/all/modules/contrib/ckeditor/ckeditor.styles.js?t=G2VC' because its MIME type ('text/x-js') is not executable, and strict MIME type checking is enabled.


Disabling the JS aggregation is just a quick fix until we figure out what is really going on.
Comment 7 Christopher Guindon CLA 2018-09-26 13:34:04 EDT
(In reply to Eric Poirier from comment #6)
> I disabled the option to "Aggregate Javascript files" and Authenticated
> users can now use the Comment field again.
> 
> The JS error I was getting was the following:
> 
> Refused to execute script from
> 'https://marketplace.eclipse.org/sites/all/modules/contrib/ckeditor/ckeditor.
> config.js?&t=G2VC' because its MIME type ('text/x-js') is not executable,
> and strict MIME type checking is enabled.
> 
> Refused to execute script from
> 'https://marketplace.eclipse.org/sites/all/modules/contrib/ckeditor/ckeditor.
> styles.js?t=G2VC' because its MIME type ('text/x-js') is not executable, and
> strict MIME type checking is enabled.
> 
> 
> Disabling the JS aggregation is just a quick fix until we figure out what is
> really going on.

Adding webmaster, I think this is a regression caused by nginx.
Comment 8 Tony Weddle CLA 2018-10-01 23:51:36 EDT
So, after the change in comment 6 the Comment field was back but also had all the other content, normally reachable via the tabs (such as metrics, and so on). I guess that was even worse so we're back at the prior situation, with no Comment field. However, I can still switch to the plain text editor, so can still add comments.
Comment 9 Christopher Guindon CLA 2018-10-02 11:50:39 EDT
(In reply to Tony Weddle from comment #8)
> So, after the change in comment 6 the Comment field was back but also had
> all the other content, normally reachable via the tabs (such as metrics, and
> so on). I guess that was even worse so we're back at the prior situation,
> with no Comment field. However, I can still switch to the plain text editor,
> so can still add comments.

I am disabling ckeditor for now until we have a solution to this problem.
Comment 10 Christopher Guindon CLA 2018-10-02 16:16:07 EDT
(In reply to Tony Weddle from comment #8)
> So, after the change in comment 6 the Comment field was back but also had
> all the other content, normally reachable via the tabs (such as metrics, and
> so on). I guess that was even worse so we're back at the prior situation,
> with no Comment field. However, I can still switch to the plain text editor,
> so can still add comments.

Our Ckeditor is now back on our website. 

Tom, could you let us know if everything is working as you are expecting?
Comment 11 Tony Weddle CLA 2018-10-08 05:03:14 EDT
(In reply to Christopher Guindon from comment #10)

> Tom, could you let us know if everything is working as you are expecting?

I think you meant Tony, Christopher. Anyway, yes, the fields are there and I would expect them to work, though I haven't had need to add comments yet, since the change.

I think this can be marked as fixed. Thanks for sorting this out.
Comment 12 Christopher Guindon CLA 2018-10-09 09:11:28 EDT
(In reply to Tony Weddle from comment #11)
> (In reply to Christopher Guindon from comment #10)
> 
> > Tom, could you let us know if everything is working as you are expecting?

Yes, my apologies!

> 
> I think you meant Tony, Christopher. Anyway, yes, the fields are there and I
> would expect them to work, though I haven't had need to add comments yet,
> since the change.
> 
> I think this can be marked as fixed. Thanks for sorting this out.

I agree!

Thanks for your help on this!