Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 539338

Summary:	[code mining] Clean code mining providers doesn't remove old code mining annotations
Product:	[Eclipse Project] Platform	Reporter:	Angelo ZERR <azerr>
Component:	Text	Assignee:	Angelo ZERR <azerr>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mistria
Version:	4.8
Target Milestone:	4.10 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/129813 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5a5fb99fe281b7cafe3731a6f4a7d6c3500e5c08
Whiteboard:
Bug Depends on:
Bug Blocks:	529127

Description Angelo ZERR

2018-09-21 23:15:09 EDT

For my contribution with JDT CodeMining https://git.eclipse.org/r/#/c/126847/ I need to clean the code mining providers of the editor according a preferences "Enable code mining".

In other words, when the editor have code mining and he changes the "Enable code mining" to false, I need to reset the registered code mining providers like this:

----------------------------------------------
sourceViewer.setCodeMiningProviders(null);
----------------------------------------------

Calling this code, doesn't remove the old code mining annotations.

Comment 1 Eclipse Genie

2018-09-21 23:17:21 EDT

New Gerrit change created: https://git.eclipse.org/r/129813

Comment 2 Mickael Istria

2018-09-24 05:48:36 EDT

Thanks Angelo!

Comment 3 Eclipse Genie

2018-09-24 05:48:53 EDT

Gerrit change https://git.eclipse.org/r/129813 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5a5fb99fe281b7cafe3731a6f4a7d6c3500e5c08

Comment 4 Angelo ZERR

2018-09-24 06:41:13 EDT

Thanks @Mickael for your great review which helped me to have a better code.