Bugzilla – Full Text Bug Listing
| Summary: | [Configuration tab] Clear configuration area before launching check box should be checked per default | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Mykola Zakharchuk <zakharchuk.vn> |
| Component: | UI | Assignee: | Mykola Zakharchuk <zakharchuk.vn> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, Vikas.Chandra |
| Version: | 3.8.2 | ||
| Target Milestone: | 4.11 M1 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/129692 https://bugs.eclipse.org/bugs/show_bug.cgi?id=67538 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=71f0052fd4ecd9adbccf15b16a361d62f00474be |
||
| Whiteboard: | |||
|
Description
Mykola Zakharchuk
New Gerrit change created: https://git.eclipse.org/r/129692 Discussion on bug 67538 is interesting, but somewhere between 2004 and 2005 the change was lost and so we are back to "not clear" again. This setting is the first thing I always check if someone asks me why the changes in plugin did not work in the runtime. It is so confusing to have it "off" by default, because the unexperienced users creating new launch configs in the hope they will fix some settings they may have changed run directly in the problem again... @Vikas, any objections to make "Clear config area" default again? >> @Vikas, any objections to make "Clear config area" default again? From the repo history, can we figure out while this was changed again after getting fixed via bug 67538? Adding Dani, may be he remembers something from 2004. (In reply to Vikas Chandra from comment #3) > >> @Vikas, any objections to make "Clear config area" default again? > > From the repo history, can we figure out while this was changed again after > getting fixed via bug 67538? Not really. There were a lot of unnamed commits from Wassim in 2005 without any explanation, like a mass move or redesign or something. May be he merged an old version over, I have no idea. My main concern is that users may be used to old behavior and find this surprising ( not in a nice way) ( though I think this may be the correct thing to do). If we check "Ask confirmations before clearing" by default then it is 1 click more for everybody. We could possibly consider a preference option to control this so that old users could just set it once and get it working for them. In-fact a better idea could be to have this clear thing off by default in preference ( simulating old behavior) and users can set it on once and then all launch configurations will use "clear configuration" on. Need more discussion. Moving to 4.10M3 (In reply to Vikas Chandra from comment #4) > Adding Dani, may be he remembers something from 2004. Dani, any idea why it was removed again? (In reply to Vikas Chandra from comment #6) > My main concern is that users may be used to old behavior and find this > surprising ( not in a nice way) ( though I think this may be the correct > thing to do). I believe no one will notice this. Only few users know why they changes don't show up in debugger. > We could possibly consider a preference option to control this so that old > users could just set it once and get it working for them. In-fact a better > idea could be to have this clear thing off by default in preference ( > simulating old behavior) and users can set it on once and then all launch > configurations will use "clear configuration" on. Sounds interesting. OK, so we want: 1) Add new option "Enable 'Clear configuration area by default' for new run configurations" preference under "Plug-in development" preferences. 2) Check *this* new option "on" by default. 3) Let the launch config dialog use this preference value as a default for new run configs. @Mykola: please update the patch. >>2) Check *this* new option "on" by default.
I am not sure if this should be "on" or "off".
With this as "off", I am sure there are no issues.
We need to see if there are huge repercussions if this option is "on".
Good to get this patch early in the iteration ! anything here? (In reply to Vikas Chandra from comment #11) > anything here? Vikas, Mykola isn't working right now on this ticket (other priorities), I guess we can count on his contribution for 4.11. +1 from changing the default to true for "Clear configuration area before launch" in 4.11 from a PMC member. (In reply to Andrey Loskutov from comment #8) > (In reply to Vikas Chandra from comment #4) > > Adding Dani, may be he remembers something from 2004. > > Dani, any idea No idea, but I also have this enabled by default. +2 to change the default. -100 to add an additional dialog. (In reply to Dani Megert from comment #14) > (In reply to Andrey Loskutov from comment #8) > > (In reply to Vikas Chandra from comment #4) > > > Adding Dani, may be he remembers something from 2004. > > > > Dani, any idea > > No idea, but I also have this enabled by default. > > +2 to change the default. > -100 to add an additional dialog. So we can take the proposed patch "AS IS"? https://git.eclipse.org/r/#/c/129692/ (In reply to Andrey Loskutov from comment #15) > (In reply to Dani Megert from comment #14) > > (In reply to Andrey Loskutov from comment #8) > > > (In reply to Vikas Chandra from comment #4) > > > > Adding Dani, may be he remembers something from 2004. > > > > > > Dani, any idea > > > > No idea, but I also have this enabled by default. > > > > +2 to change the default. > > -100 to add an additional dialog. > > So we can take the proposed patch "AS IS"? > https://git.eclipse.org/r/#/c/129692/ Yes, for 4.11. Gerrit change https://git.eclipse.org/r/129692 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=71f0052fd4ecd9adbccf15b16a361d62f00474be Verified with I20181212-1800. Should there be a N&N item for this? |