Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 538821

Summary:	[JFace] Give the snippets some love
Product:	[Eclipse Project] Platform	Reporter:	Wim Jongman <wim.jongman>
Component:	UI	Assignee:	Wim Jongman <wim.jongman>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel
Version:	4.8
Target Milestone:	4.9
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/129038 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac4c2ea9905cadf4f652220d8476c9237726f603 https://bugs.eclipse.org/bugs/show_bug.cgi?id=517461 https://bugs.eclipse.org/bugs/show_bug.cgi?id=443717
Whiteboard:

Description Wim Jongman

2018-09-08 06:19:06 EDT

I am in the process of updating the jface snippets wiki [1]

* Added usage explanation on top of the page
* Changed all links to go the plain source directly

TODO
* Replace all references to "new API" with "API"
* In process of adding images to all snippets

I have created a regex to add image links to the wiki. So a lot of images are still to be filled in. I added about a dozen but there are still a lot to be done. 

If you need a quiet moment with some dull work to contemplate your sins then please join me in updating this page.


[1] https://wiki.eclipse.org/JFaceSnippets

Comment 1 Lars Vogel

2018-09-09 10:40:17 EDT

Thanks Wim looks cool.

Shall we delete Snippet021CellEditorsOnDoubleClick? Feels outdated.

Comment 2 Lars Vogel

2018-09-09 10:43:03 EDT

Same for Snippet042ToolTipSupportFor32API

Comment 3 Wim Jongman

2018-09-09 15:34:40 EDT

Yes, cool, I have already removed one or two old ones. I will weed out these as well.

Comment 4 Eclipse Genie

2018-09-10 07:40:10 EDT

New Gerrit change created: https://git.eclipse.org/r/129038

Comment 5 Eclipse Genie

2018-09-10 07:42:24 EDT

Gerrit change https://git.eclipse.org/r/129038 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac4c2ea9905cadf4f652220d8476c9237726f603

Comment 6 Wim Jongman

2018-09-10 07:43:04 EDT

* Added button text to Snippet041
* Added button text to Snippet043
* Added initial input to Snippet045
* Added some excitement to Snippet046
* Overhaul of lazy treeviewer snippet047
* Added a cool barcode for snippet051 
* Prevented crash on wrong input for snippet053
* Javadoc on Snippet058
* Screen size on Snippet058
* Random element selection on snippet063
* Changed text in Snippet020
* Deleted Snippet021. Old 3.1 style madness
* Deleted Snippet042. Old API

Comment 7 Wim Jongman

2018-09-10 07:43:42 EDT

Also added images to every snippet:

https://wiki.eclipse.org/JFaceSnippets