Bugzilla – Full Text Bug Listing
| Summary: | Heap status indicator renders with black text and black bar on macOS 10.14 (Mojave) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Torkild Resheim <torkildr> | ||||||
| Component: | UI | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, hubert+eclipseorg, Lars.Vogel, lshanmug, ma.becker, p.belusky, rgrunber, tza | ||||||
| Version: | 4.8 | ||||||||
| Target Milestone: | 4.10 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X | ||||||||
| See Also: |
https://git.eclipse.org/r/132664 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=177d800acd913c62eb4c5f0143a8a9e0aea55c7f |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 538976 | ||||||||
| Attachments: |
|
||||||||
Which theme are you using? Dark or light? Is it a regression compared to 4.7? On Windows it looks OK for both themes. (In reply to Dani Megert from comment #1) > Which theme are you using? Dark or light? > Is it a regression compared to 4.7? > On Windows it looks OK for both themes. I'm using the light theme and it's not a regression. It looks the same in 4.7. I'm guessing Apple has done some significant changes in order to support the dark theme and that the color picked up for the bar is simply wrong. It should probably be the "highlight" colour on macOS. I'll have a look at the code. (In reply to Torkild Resheim from comment #2) > 4.7. I'm guessing Apple has done some significant changes in order to > support the dark theme and that the color picked up for the bar is simply In case it's not clear: macOS 10.14 comes with two themes, "dark" and "light". So, in this case, I used the macOS light theme and the Eclipse light theme. Created attachment 275330 [details]
Black frames in compare view
It appears the compare view is displaying a similar problem. The frames should be in some gray colour.
See also bug #466275 A good starting point would be Bug 537812, I addressed the issue for Linux. I think i restricted it in that way because finding a colour that looked good everywhere was too complicated. Maybe looking through the SWT colour constants on MacOS may give a better idea of what might work. Typo. I meant Bug 533778. (In reply to Roland Grunberg from comment #7) > Typo. I meant Bug 533778. Thanks. Also, note that the color does not change when switching to the macOS dark theme. Same behaviour with Fedora 28, default Theme or custom Theme and new Eclipse 4.9. I've posted details and attachment in bug #381010. This might be somewhat related to the other bug. https://bugs.eclipse.org/bugs/show_bug.cgi?id=381010 On Mac 10.14, SWT.COLOR_WIDGET_NORMAL_SHADOW returns black, causing the heap status to be rendered black. I think it's safer to change to a fixed Color as the system colors for the constants keep changing. Matthias, something for you? If no one is working on it yet, I can fix it for Mac. (In reply to Lakshmi Shanmugam from comment #13) > If no one is working on it yet, I can fix it for Mac. that would be great. (In reply to Lakshmi Shanmugam from comment #13) > If no one is working on it yet, I can fix it for Mac. Please use a fix color for all platforms, to avoid other color issues in other platform. I'm available to test on Linux in the light and dark theme. New Gerrit change created: https://git.eclipse.org/r/132664 (In reply to Eclipse Genie from comment #16) > New Gerrit change created: https://git.eclipse.org/r/132664 In the patch, userMemCol uses RGB(160, 160, 160) which is the color picked on Windows and close to the color picked on Mac in 10.13 - RGB(159,159,159). Lars, can you please test on Linux? (In reply to Lakshmi Shanmugam from comment #17) > Lars, can you please test on Linux? Looks good on Linux (light and dark theme). (In reply to Lars Vogel from comment #18) > (In reply to Lakshmi Shanmugam from comment #17) > > Lars, can you please test on Linux? > > Looks good on Linux (light and dark theme). Thanks! Tested on Mac 10.14 and Windows, looks good on both. Gerrit change https://git.eclipse.org/r/132664 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=177d800acd913c62eb4c5f0143a8a9e0aea55c7f Verified with I20181119-2315 on Mac 10.14. |
Created attachment 275325 [details] Screenshot demonstrating the issue Found using Eclipse IDE for RCP and RAP Developers 4.8.