Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 537231

Summary: Deadlocks occuring when workflow page of aird editor is opened.
Product: [Modeling] Sirius Reporter: Pierre Guilet <pierre.guilet>
Component: CoreAssignee: Project inbox <sirius.core-inbox>
Status: CLOSED FIXED QA Contact: Florian Barbin <florian.barbin>
Severity: normal    
Priority: P3 CC: florian.barbin, julien.dupont, pierre-charles.david
Version: 6.0.0   
Target Milestone: 6.0.1   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/126647
https://git.eclipse.org/r/126751
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=340e321d2adbd4729835b73b703234b6f5bf070e
Whiteboard:
Bug Depends on:    
Bug Blocks: 536066, 537232    
Attachments:
Description Flags
java stack none

Description Pierre Guilet CLA 2018-07-20 09:53:00 EDT
Created attachment 275070 [details]
java stack

The deadlock occurred in the following situations:

- when editing the local odesign file
- when using the "Add model" action on the Project dependencies element, but not at each time.

The stack trace of all threads is attached to this ticket.
Comment 1 Eclipse Genie CLA 2018-07-26 05:33:56 EDT
New Gerrit change created: https://git.eclipse.org/r/126647
Comment 2 Eclipse Genie CLA 2018-07-30 04:47:34 EDT
New Gerrit change created: https://git.eclipse.org/r/126751
Comment 4 Pierre-Charles David CLA 2018-07-30 08:44:48 EDT
Fixed by 340e321d2adbd4729835b73b703234b6f5bf070e.
Comment 5 Pierre Guilet CLA 2018-08-01 05:25:34 EDT
Steps to reproduce:

- Do a remote debug
- Create a modeling project with an ecore file
- Put a breakpoint at WorkflowHelper.getWorkflowDescriptions(WorkflowHelper.java:65)
- Right click on project in model explorer>Viewpoint selection
- Select design viewpoint
- Ok
- Verify you only have one thread at a time that break and not more than one at the same time.
Comment 6 Florian Barbin CLA 2018-08-03 04:35:31 EDT
I can easily have multiple thread stopped at the mentioned breakpoint. Set the focus on the workflow tab: a first thread is stopped at the breakpoint.
Select an other viewpoint: a second thread is stopped at the breakpoint.
Comment 7 Pierre-Charles David CLA 2018-08-22 03:33:57 EDT
After exchanging with Pierre and Florian, we believe the bug is fixed, it's just that the steps to reproduce mentioned in comment 5 allow for situations which will never occur in practice.
Comment 8 Pierre-Charles David CLA 2018-08-27 04:13:57 EDT
Available in Sirius 6.0.1, see https://wiki.eclipse.org/Sirius/6.0.1 for details.