Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 537134

Summary:	The order of custom colors in the Appearance tab's palette is not consistent with the VSM definition order
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Diagram	Assignee:	Laurent Fasani <laurent.fasani>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	frederic.madiot, julien.dupont, pierre-charles.david, sirius.diagram-inbox, steve.monnier
Version:	6.0.0
Target Milestone:	6.1.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/129141 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7276ce04499b3b795f85beb3013a93122d42cd7e https://git.eclipse.org/r/129522 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=79b39822720b815ceb247379e347f30f748dc394 https://bugs.eclipse.org/bugs/show_bug.cgi?id=539156
Whiteboard:
Bug Depends on:	536465
Bug Blocks:

Description Pierre-Charles David

2018-07-18 04:52:16 EDT

+++ This bug was initially created as a clone of Bug #536465 +++

In the color palette provided to the end-user, the order of the custom colors (defined in the odesign with a User Color Palette) should be sorted from their position in the User Color Palette (it seems they are sorted on the creation order)

Comment 1 Pierre-Charles David

2018-07-18 04:52:42 EDT

Clone to report the fix made for 6.0.1 on master for 6.1.0.

Comment 2 Eclipse Genie

2018-09-13 12:18:29 EDT

Gerrit change https://git.eclipse.org/r/129141 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7276ce04499b3b795f85beb3013a93122d42cd7e

Comment 3 Laurent Fasani

2018-09-13 12:22:42 EDT

An ui preference managed in Windows/Preferences has been added to choose if the user fixed colors defined in VSM are displayed in the color palette.
By default, its value is true.

Comment 4 Laurent Fasani

2018-09-13 12:23:34 EDT

A documentation and the steps to validate are still required to resolve this ticket.

Comment 5 Eclipse Genie

2018-09-17 06:09:37 EDT

New Gerrit change created: https://git.eclipse.org/r/129522

Comment 6 Eclipse Genie

2018-09-17 09:31:52 EDT

Gerrit change https://git.eclipse.org/r/129522 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=79b39822720b815ceb247379e347f30f748dc394

Comment 7 Laurent Fasani

2018-09-17 09:48:31 EDT

Steps to validate

steps to reproduce
SCENARIO1
0- Preference/Sirius/Sirius Diagram/Appearance/ check "Display viewpoint colors"
1- select a node in a diagram
2- display Properties view/Appearance tab
3- click on text color
-> colors are displayed in this order
* grayed colors
* colors defined in the VSM of the diagram
* system colors(rainbow) 
4- hover the colors
-> the tooltip diplays the name of the color
5- repeat steps 3 and 4 with line anf fill button
6- repeat steps 1 to 5 selecting 
   * a diagram
   * an edge
   * a label

SCENARIO2
0- Preference/Sirius/Sirius Diagram/Appearance/ UNcheck "Display viewpoint colors"
1- select a node in a diagram
2- display Properties view/Appearance tab
3- click on text color
-> viewpoint colors are not displayed. Only grayed and system colors are displayed

Comment 8 Pierre-Charles David

2018-10-19 12:48:02 EDT

Available in Sirius 6.1.0, see https://wiki.eclipse.org/Sirius/6.1.0