Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 536385

Summary: Marketplace client does not open when Eclipse is renamed
Product: [Technology] MPC Reporter: Butch Anton <butch>
Component: wizardAssignee: Project Inbox <mpc.wizard-inbox>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: akshaysumbe, andreas.gottardi, bigfootsergent, daniel_megert, dream1571, dwagelaar, frederic.gurr, g3949, gunnar, Hawkeyes0, John.holliday, kamilkime, kingjon3377, mail, mansi190594, mg.garmash, mp, msamsel, philippn, prog85, puneetsapaliga21, pyvesdev, rbrown_3, reckord, renesigi, richard.bibb, sayseakleng, tschoening, Yousha.A
Version: unspecified   
Target Milestone: 1.7.1   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:

Description Butch Anton CLA 2018-06-28 01:14:26 EDT
If the Eclipse application is renamed (say, to Eclipse Photon), the marketplace client will not open.  Renaming the application back to Eclipse allows the marketplace client to open.
Comment 1 Philipp Nanz CLA 2018-06-28 03:04:59 EDT
This seems to be a general problem when the Eclipse installation folder contains spaces. I am encountering the same on a Windows 10.
Comment 2 Carsten Reckord CLA 2018-06-28 04:12:35 EDT
Yes it's a general problem with spaces in the Eclipse installation path. I've found the problem and will push a new Marketplace Client release later today.
Comment 3 Carsten Reckord CLA 2018-06-28 04:22:19 EDT
*** Bug 536167 has been marked as a duplicate of this bug. ***
Comment 4 Carsten Reckord CLA 2018-06-28 08:32:35 EDT
This was caused by a fix for a problem surfaced by bug 535039. I fixed the problem as part of that, but have now created bug 536414 to document that fix explicitly, since it was the cause of this issue.

This issue is caused by a URL-to-URI conversion for the configuration area path, where MPC stores state information. If the configuration area path contains a space, that space is not encoded in the URL and breaks the URI conversion. 

This was fixed in commit b1618565d6b17dc38751425def832f0936304828.
Comment 5 Carsten Reckord CLA 2018-06-28 08:32:56 EDT
For now, please install the update from http://download.eclipse.org/mpc/photon using "Help / Install New Software". 

It won't be available through "Check for updates" for now - I'll need to go through the release process to push the release bits to  the appropriate places first...

I'll leave this open until then and keep you posted.
Comment 6 Thorsten Schöning CLA 2018-06-28 10:24:20 EDT
Does the release process include publishing new release-Zips as well? Because in my setup the Java EE release-Zip is deployed system wide and current users don't have write access to those directories, so updating within Eclipse won't work.
Comment 7 Philipp Nanz CLA 2018-06-28 10:47:08 EDT
It's working with the update from http://download.eclipse.org/mpc/photon. Thank you!
Comment 8 Carsten Reckord CLA 2018-06-28 12:00:02 EDT
*** Bug 536281 has been marked as a duplicate of this bug. ***
Comment 9 Carsten Reckord CLA 2018-06-28 12:03:57 EDT
(In reply to Thorsten Schöning from comment #6)
> Does the release process include publishing new release-Zips as well?
> Because in my setup the Java EE release-Zip is deployed system wide and
> current users don't have write access to those directories, so updating
> within Eclipse won't work.

I can't say yet. But in that setup, I would expect your clients not to be affected at all. 

With a read-only install, the path that would trigger the error is replaced with a writeable overlay in $HOME/.eclipse. So unless that contains spaces as well, it should work.
Comment 10 Thorsten Schöning CLA 2018-06-28 13:26:02 EDT
(In reply to Carsten Reckord from comment #9)
> I can't say yet. But in that setup, I would expect your clients not to be
> affected at all. 

I am, like can be read in Bug 536281 Comment 1, because Eclipse is started with multiple different command line switches resulting in different workspaces etc. like in the following example:

> "C:\Program Files\Eclipse\eclipse.exe" -configuration "%APPDATA%\Eclipse\Java GitHub\configuration" -data "%USERPROFILE%\Documents\Eclipse\Java GitHub"
Comment 11 Carsten Reckord CLA 2018-06-29 03:22:35 EDT
*** Bug 536447 has been marked as a duplicate of this bug. ***
Comment 12 Carsten Reckord CLA 2018-06-29 08:11:17 EDT
*** Bug 536457 has been marked as a duplicate of this bug. ***
Comment 13 Richard Bibb CLA 2018-06-29 11:42:37 EDT
(In reply to Philipp Nanz from comment #7)
> It's working with the update from http://download.eclipse.org/mpc/photon.
> Thank you!

This fix doesn't appear to work for me

  Marketplace Client	1.7.1.v20180628-1155	org.eclipse.epp.mpc.feature.group	Eclipse Marketplace Client

Caused by: java.lang.IllegalArgumentException: Illegal character in path at index 22: file:/C:/Users/Richard Bibb/.eclipse/org.eclipse.platform_4.8.0_581752649_win32_win32_x86_64/configuration/
	at java.net.URI.create(Unknown Source)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.computeConfigurationAreaRegistryFile(MarketplaceInfo.java:445)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.createRegistryFile(MarketplaceInfo.java:408)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.load(MarketplaceInfo.java:341)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.getInstance(MarketplaceInfo.java:330)
	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceDiscoveryStrategy.<init>(MarketplaceDiscoveryStrategy.java:109)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplaceWizard.initializeCatalog(MarketplaceWizard.java:922)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.setVisible(MarketplacePage.java:831)
	at org.eclipse.jface.wizard.WizardDialog.showStartingPage(WizardDialog.java:1220)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:576)
	at org.eclipse.jface.window.Window.create(Window.java:426)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1096)
	at org.eclipse.jface.window.Window.open(Window.java:783)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.openWizardDialog(AbstractMarketplaceWizardCommand.java:145)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.execute(AbstractMarketplaceWizardCommand.java:72)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
Comment 14 Carsten Reckord CLA 2018-06-29 12:12:34 EDT
(In reply to Richard Bibb from comment #13)
> (In reply to Philipp Nanz from comment #7)
> > It's working with the update from http://download.eclipse.org/mpc/photon.
> > Thank you!
> 
> This fix doesn't appear to work for me
> 
>   Marketplace Client	1.7.1.v20180628-1155	org.eclipse.epp.mpc.feature.group
> Eclipse Marketplace Client
> 
> Caused by: java.lang.IllegalArgumentException: Illegal character in path at
> index 22: file:/C:/Users/Richard
> Bibb/.eclipse/org.eclipse.platform_4.8.0_581752649_win32_win32_x86_64/
> configuration/
> 	at java.net.URI.create(Unknown Source)
> 	at
> org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.
> computeConfigurationAreaRegistryFile(MarketplaceInfo.java:445)

That's strange. The Feature version is correct, but the exception corresponds to the old version's line numbers. Could you please try to start Eclipse with -clean once?
Comment 15 Andrey Loskutov CLA 2018-06-30 08:46:16 EDT
*** Bug 536534 has been marked as a duplicate of this bug. ***
Comment 16 Wayne Beaton CLA 2018-07-03 11:51:07 EDT
*** Bug 536591 has been marked as a duplicate of this bug. ***
Comment 17 Peter Fischer CLA 2018-07-04 16:00:47 EDT
http://download.eclipse.org/mpc/photon -> solved my problem

Thanks,

FP
Comment 18 Alois Zoitl CLA 2018-07-09 06:50:31 EDT
*** Bug 536824 has been marked as a duplicate of this bug. ***
Comment 19 Alois Zoitl CLA 2018-07-20 17:49:40 EDT
*** Bug 537242 has been marked as a duplicate of this bug. ***
Comment 20 Dani Megert CLA 2018-07-22 05:28:47 EDT
*** Bug 537085 has been marked as a duplicate of this bug. ***
Comment 21 Carsten Reckord CLA 2018-07-30 08:57:34 EDT
*** Bug 537495 has been marked as a duplicate of this bug. ***
Comment 22 Dani Megert CLA 2018-08-07 05:29:47 EDT
*** Bug 537743 has been marked as a duplicate of this bug. ***
Comment 23 Dani Megert CLA 2018-08-13 04:02:01 EDT
*** Bug 537876 has been marked as a duplicate of this bug. ***
Comment 24 Dani Megert CLA 2018-08-13 04:32:27 EDT
*** Bug 537878 has been marked as a duplicate of this bug. ***
Comment 25 Carsten Reckord CLA 2018-08-13 08:11:19 EDT
*** Bug 536447 has been marked as a duplicate of this bug. ***
Comment 26 Robert Brown III CLA 2018-08-13 10:35:55 EDT
A point of information:

   It appears that the Marketplace is completely disabled on Photon. I have attempted to run it in order to download some needed plugins. Clicking on the menu item elicits no response at all. The marketplace simply does not start.
Comment 27 Pierre-Yves Bigourdan CLA 2018-08-13 11:12:58 EDT
Robert, have you tried installing the latest version from the update site (http://download.eclipse.org/mpc/photon)? There are also other unresolved issues with the Marketplace Client in Eclipse Photon, for instance when theming is disabled (see Bug 537717).
Comment 28 Carsten Reckord CLA 2018-09-07 04:01:32 EDT
*** Bug 538056 has been marked as a duplicate of this bug. ***
Comment 29 Christopher Guindon CLA 2018-09-11 13:50:13 EDT
*** Bug 538939 has been marked as a duplicate of this bug. ***
Comment 30 Carsten Reckord CLA 2018-09-17 05:51:27 EDT
*** Bug 539135 has been marked as a duplicate of this bug. ***
Comment 31 Carsten Reckord CLA 2018-09-17 06:35:31 EDT
*** Bug 537704 has been marked as a duplicate of this bug. ***
Comment 32 Carsten Reckord CLA 2018-09-18 08:48:48 EDT
Marking as fixed. The fixed version will be part of Eclipse 2018-09. 

As mentioned before, Photon users can update their Marketplace Client using "Help / Install New Software" using http://download.eclipse.org/mpc/photon.
Comment 33 Carsten Reckord CLA 2018-09-19 06:22:46 EDT
*** Bug 539194 has been marked as a duplicate of this bug. ***
Comment 34 Mansi Upadhyay CLA 2019-04-04 00:59:43 EDT
(In reply to Carsten Reckord from comment #32)
> Marking as fixed. The fixed version will be part of Eclipse 2018-09. 
> 
> As mentioned before, Photon users can update their Marketplace Client using
> "Help / Install New Software" using http://download.eclipse.org/mpc/photon.

I have tried this URL : http://download.eclipse.org/mpc/photon , But my eclipse is not able to find the URL. Is there any other URL in place ?
Comment 35 Mansi Upadhyay CLA 2019-04-04 01:03:38 EDT
I have tried getting the download URL from : "https://marketplace.eclipse.org/content/eclipse-marketplace-client" for photon marketplace as below :

https://download.eclipse.org/mpc/photon/latest/


which is also seems to be down. Could you please help in getting the correct URL. 
Thank you in advance.
Comment 36 Carsten Reckord CLA 2019-04-04 04:24:47 EDT
Both of these work for me and are the correct URLs. You could try an individual release, e.g. http://download.eclipse.org/mpc/releases/1.7.5. 

But I suspect that there's either a problem with your internet connection, or you are using a proxy and that isn't correctly configured in your Eclipse. Can you open any of these URLs successfully in a browser? Do other update sites work for you in Eclipse?