Bugzilla – Full Text Bug Listing
| Summary: | [GTK 3.22] Combo overlaps with label on resize | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Simeon Andreev <simeon.danailov.andreev> |
| Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> |
| Status: | CLOSED DUPLICATE | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | ericwill, loskutov |
| Version: | 4.8 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500703 https://bugs.eclipse.org/bugs/show_bug.cgi?id=539367 |
||
| Whiteboard: | |||
| Attachments: | |||
Created attachment 274379 [details]
OK behaviour seen with the snippet on GTK 3.14.
Created attachment 274380 [details]
Bad behaviour seen with the snippet on GTK 3.22.
I also observe the unwanted behaviour with Adwaita (GTK 3.22). The attached gifs are taken with Clearlooks Phenix theme though.
Interesting, looks like some bugs made it after the fixes for bug 500703. I'll investigate. Just out of curiosity, does the issue reproduce when using a Combo that *does not* have SWT.READ_ONLY specified? (In reply to Eric Williams from comment #5) > Just out of curiosity, does the issue reproduce when using a Combo that > *does not* have SWT.READ_ONLY specified? Not that I see, at least for the part of our product for which we received a report and in the attached snippet. Thank for checking this! Hi Eric, I've put some debug outputs in Composite.fixChildClippings(), to check when the fix is applied. After shrinking the attached snippet enough to apply the negative clipping fix from bug 500703, I see *constant and endless* redraws. Is this really intended? Best regards, Simeon (In reply to Simeon Andreev from comment #7) > Hi Eric, > > I've put some debug outputs in Composite.fixChildClippings(), to check when > the fix is applied. After shrinking the attached snippet enough to apply the > negative clipping fix from bug 500703, I see *constant and endless* redraws. > > Is this really intended? > > Best regards, > Simeon Yes, it's necessary unfortunately -- as of GTK3.20 the drawing model changed (again). We have to fix the clippings of all the Combo's children in order to make sure nothing is overdrawn. If I find a better solution I'll implement it but this is all I have found to work so far. (In reply to Eric Williams from comment #8) > Yes, it's necessary unfortunately -- as of GTK3.20 the drawing model changed > (again). :-) The root cause of this bug is the same as bug 535323. *** This bug has been marked as a duplicate of bug 535323 *** Thanks! |
Created attachment 274378 [details] SWT snippet to reproduce the problem with. Shrink shell width to observe the problem. To reproduce: 1. Run snippet "BugComboOverlapsWithLabelOnResize.java" 2. Reduce shell width by resizing with the mouse. 3. Observe combos overlapping with labels. Behaviour is nearly fixed, by changing line 41 in the snippet: - GridLayout gridLayout = new GridLayout(2, false); + GridLayout gridLayout = new GridLayout(2, true); I.e. request equal column sizes in the group. There is still minor issue with the longer combo (middle combo), namely the left end gets cut off. But this is not dramatic. Seen with: Eclipse SDK Version: Photon (4.8) Build id: I20180531-0700 RHEL 7.4 GTK 3.22.10 GTK 3.14.13 seems to be fine.