Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 535382

Summary: Use pomless builds for bundles in eclipse.platform.ui
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtako, akurtakov, daniel_megert, jonah, Lars.Vogel, malaperle, sravankumarl
Version: 4.8   
Target Milestone: 4.13 M1   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/136216
https://git.eclipse.org/r/141152
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=8b7005613dc46c9314744aae9045c3e86cb68b15
https://git.eclipse.org/r/141153
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0dbc8e442fca8d5fb3509c1617fb4bed1950b978
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d15c3c251d69778417c1390c180553538a497931
https://git.eclipse.org/r/141309
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6f6f54d027897abce4b22c9526ee0d3ddbd9fa80
https://git.eclipse.org/r/141443
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4cc8544c7ba280421d7a554ce512bcc4c46a3979
https://git.eclipse.org/r/141501
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=270edd1804dbbe63d7eff0a86f67bd8cf8fe2c60
https://git.eclipse.org/r/141565
https://bugs.eclipse.org/bugs/show_bug.cgi?id=546836
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1040807658b094c2534e36a56122142dfebb2e88
Whiteboard:
Bug Depends on: 482474    
Bug Blocks:    

Description Lars Vogel CLA 2018-05-31 05:51:21 EDT

    
Comment 1 Eclipse Genie CLA 2019-02-04 03:39:26 EST
New Gerrit change created: https://git.eclipse.org/r/136216
Comment 2 Lars Vogel CLA 2019-02-19 03:31:30 EST
Mass change, please reset target if you still planning to fix this for 4.11.
Comment 3 Lars Vogel CLA 2019-04-25 08:32:28 EDT
Awaiting feedback from Alex, who wanted to test this change in the aggregator build.
Comment 4 Alexander Kurtakov CLA 2019-04-25 10:21:18 EDT
Some changes in releng.aggregator needed too - the extension I'll handle it now.
Comment 5 Eclipse Genie CLA 2019-04-25 10:24:53 EDT
New Gerrit change created: https://git.eclipse.org/r/141152
Comment 7 Eclipse Genie CLA 2019-04-25 10:28:38 EDT
New Gerrit change created: https://git.eclipse.org/r/141153
Comment 9 Lars Vogel CLA 2019-04-26 06:22:59 EDT
Sravan, I'm going to merge the first test commit, please feel free to revert if that affects the aggregator build.
Comment 11 Eclipse Genie CLA 2019-04-29 03:58:34 EDT
New Gerrit change created: https://git.eclipse.org/r/141309
Comment 13 Dani Megert CLA 2019-05-01 04:58:03 EDT
https://download.eclipse.org/eclipse/downloads/drops4/I20190430-1800/testResults.php


jface 	0 	250
ui.ide 	0 	512
ui.navigator 	0 	283
ui.views.log 	0 	18
ui.views.properties.tabbed 	0 	129
ui.workbench 	0 	2888
Comment 14 Dani Megert CLA 2019-05-01 05:00:40 EDT
The warnings are there because important properties got removed by removing the whole pom.xml.

Reverting...
Comment 15 Eclipse Genie CLA 2019-05-01 05:01:21 EDT
New Gerrit change created: https://git.eclipse.org/r/141443
Comment 17 Dani Megert CLA 2019-05-01 05:10:18 EDT
You need to check each POM file whether it contains non-trivial stuff like e.g. setting a property that is used by our build. Those you can't delete. I don't know whether it would work to only delete the trivial parts.
Comment 18 Jonah Graham CLA 2019-05-01 07:00:59 EDT
(In reply to Dani Megert from comment #17)
> I don't know whether it would work to only delete the trivial parts.

Hi folks, I thought I would let you know what CDT did to resolve this issue so that we went (mostly) pomless. Not sure if you have an alternative solution, so I will be watching this bug to see what you do. 

Using auto-activation profiles and "magic" files CDT turns on different settings for different plug-ins. For example if there is a file called ui-test-plugin.properties[1] in the project, the UI test profile applies with additional settings[2]. You can probably adapt to do the same for platform?

For plug-ins that are uniquely different the pom's were preserved.

This work was originally done for CDT by Marc-Andre[3]


[1] https://github.com/eclipse-cdt/cdt/blob/cbf526193abf940de04162e609ef2efd430b9a68/dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/ui-test-plugin.properties
[2] https://github.com/eclipse-cdt/cdt/blob/cbf526193abf940de04162e609ef2efd430b9a68/pom.xml#L349
[3] https://git.eclipse.org/r/#/c/90459/ .

HTH,
Jonah
Comment 19 Eclipse Genie CLA 2019-05-02 04:41:35 EDT
New Gerrit change created: https://git.eclipse.org/r/141501
Comment 21 Eclipse Genie CLA 2019-05-03 05:02:34 EDT
New Gerrit change created: https://git.eclipse.org/r/141565
Comment 23 Alexander Kurtakov CLA 2019-05-17 03:52:17 EDT
Removing target as if it requires Tycho change it may take a while.
Comment 24 Lars Vogel CLA 2019-08-20 01:53:21 EDT
Lets consider this fixed and open a new bug, once Tycho provides requested functionality.