|
Description
Lars Vogel
New Gerrit change created: https://git.eclipse.org/r/136216 Mass change, please reset target if you still planning to fix this for 4.11. Awaiting feedback from Alex, who wanted to test this change in the aggregator build. Some changes in releng.aggregator needed too - the extension I'll handle it now. New Gerrit change created: https://git.eclipse.org/r/141152 Gerrit change https://git.eclipse.org/r/141152 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=8b7005613dc46c9314744aae9045c3e86cb68b15 New Gerrit change created: https://git.eclipse.org/r/141153 Gerrit change https://git.eclipse.org/r/141153 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0dbc8e442fca8d5fb3509c1617fb4bed1950b978 Sravan, I'm going to merge the first test commit, please feel free to revert if that affects the aggregator build. Gerrit change https://git.eclipse.org/r/136216 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d15c3c251d69778417c1390c180553538a497931 New Gerrit change created: https://git.eclipse.org/r/141309 Gerrit change https://git.eclipse.org/r/141309 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6f6f54d027897abce4b22c9526ee0d3ddbd9fa80 https://download.eclipse.org/eclipse/downloads/drops4/I20190430-1800/testResults.php jface 0 250 ui.ide 0 512 ui.navigator 0 283 ui.views.log 0 18 ui.views.properties.tabbed 0 129 ui.workbench 0 2888 The warnings are there because important properties got removed by removing the whole pom.xml. Reverting... New Gerrit change created: https://git.eclipse.org/r/141443 Gerrit change https://git.eclipse.org/r/141443 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4cc8544c7ba280421d7a554ce512bcc4c46a3979 You need to check each POM file whether it contains non-trivial stuff like e.g. setting a property that is used by our build. Those you can't delete. I don't know whether it would work to only delete the trivial parts. (In reply to Dani Megert from comment #17) > I don't know whether it would work to only delete the trivial parts. Hi folks, I thought I would let you know what CDT did to resolve this issue so that we went (mostly) pomless. Not sure if you have an alternative solution, so I will be watching this bug to see what you do. Using auto-activation profiles and "magic" files CDT turns on different settings for different plug-ins. For example if there is a file called ui-test-plugin.properties[1] in the project, the UI test profile applies with additional settings[2]. You can probably adapt to do the same for platform? For plug-ins that are uniquely different the pom's were preserved. This work was originally done for CDT by Marc-Andre[3] [1] https://github.com/eclipse-cdt/cdt/blob/cbf526193abf940de04162e609ef2efd430b9a68/dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/ui-test-plugin.properties [2] https://github.com/eclipse-cdt/cdt/blob/cbf526193abf940de04162e609ef2efd430b9a68/pom.xml#L349 [3] https://git.eclipse.org/r/#/c/90459/ . HTH, Jonah New Gerrit change created: https://git.eclipse.org/r/141501 Gerrit change https://git.eclipse.org/r/141501 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=270edd1804dbbe63d7eff0a86f67bd8cf8fe2c60 New Gerrit change created: https://git.eclipse.org/r/141565 Gerrit change https://git.eclipse.org/r/141565 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1040807658b094c2534e36a56122142dfebb2e88 Removing target as if it requires Tycho change it may take a while. Lets consider this fixed and open a new bug, once Tycho provides requested functionality. |