Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 535047

Summary:	Text filter not working in Preferences
Product:	[Eclipse Project] Platform	Reporter:	Noopur Gupta <noopur_gupta>
Component:	UI	Assignee:	Mickael Istria <mistria>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P2	CC:	akurtakov, daniel_megert, lbullen, mistria, noopur_gupta
Version:	4.8	Flags:	akurtakov: review+ daniel_megert: review+
Target Milestone:	4.8 RC2
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/123236 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=db3a91066472921526c2935d96a6d040048f39a7
Whiteboard:
Bug Depends on:	534277
Bug Blocks:

Description Noopur Gupta

2018-05-24 03:02:29 EDT

I20180523-2000

Open Preferences and type "jre".
=> No result found.

This was working in I20180520-2000.
=> Regression.

Comment 1 Mickael Istria

2018-05-24 03:55:24 EDT

I confirm the commit for bug 534277 causes this.

Comment 2 Mickael Istria

2018-05-24 04:22:00 EDT

Adding
"""
filter.setPattern("jre");
assertTrue(filter.select(viewer, null, "Java build path buildpath problem exclusion inclusion pattern folder outputfolder filtered resource output compiler 1.5 5.0 J2SE5 project specific projectspecific strictly compatible JRE execution environment"));
"""
and
"""
filter.setPattern("b");
assertTrue(filter.select(viewer, null, "a b c"));
""" 
in PatternFilterTest clearly show the issue.

Comment 3 Mickael Istria

2018-05-24 04:56:16 EDT

Making it a candidate for RC3.

Comment 4 Eclipse Genie

2018-05-24 04:59:41 EDT

New Gerrit change created: https://git.eclipse.org/r/123236

Comment 5 Dani Megert

2018-05-24 06:31:16 EDT

(In reply to Mickael Istria from comment #3)
> Making it a candidate for RC3.

If we get enough +1s today, I'd prefer to respin RC2. Will look at this after lunch.

Comment 6 Dani Megert

2018-05-24 08:24:33 EDT

(In reply to Dani Megert from comment #5)
> (In reply to Mickael Istria from comment #3)
> > Making it a candidate for RC3.
> 
> If we get enough +1s today, I'd prefer to respin RC2. Will look at this
> after lunch.

We're good. I think we will respin RC2. I'm currently looking at another bad regression.

Comment 7 Eclipse Genie

2018-05-24 08:38:51 EDT

Gerrit change https://git.eclipse.org/r/123236 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=db3a91066472921526c2935d96a6d040048f39a7

Comment 8 Dani Megert

2018-05-24 12:21:53 EDT

Verified in eclipse-SDK-I20180524-0900-win32-x86_64.