Bugzilla – Full Text Bug Listing
|
Description
Ed Willink
Fix committed in http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=a97cfd17512ccf4241d7a2a0dc407a146585e22a Included in ATL 4.0.0 release. Ed, can you verify? Verified for RC3. Unfortunately MWE has yet to migrate. Unfortunately the EMFTVM feature specifies real versions rather than just the default 0.0.0, so the problem in both plugins and features is only fixed in the plugins.
<import plugin="org.eclipse.ui.ide"/>
...
<import plugin="org.objectweb.asm" version="5.0.1" match="compatible"/>
We don't seem to have an ATL 4.0.1 for 2018-09 so ATL installation forces in an additional ASM. New Gerrit change created: https://git.eclipse.org/r/128993 Gerrit change https://git.eclipse.org/r/128993 was merged to [master]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=6ec4cdb8040586da838e3e39c3a6c174c41cd652 A totally open upper boound is a bit dangerous. Why knows what ASM 7 will bring? For OCL I set the bounds as 5 or 6. (In reply to Ed Willink from comment #8) > A totally open upper boound is a bit dangerous. Why knows what ASM 7 will > bring? > > For OCL I set the bounds as 5 or 6. It's set as "[5.0.1, 7.0)" in the plug-in, but the feature.xml only allows you to specify a single version with a match rule. I simply relaxed that rule one step from "Compatible" to "Greater or Equal". This is also consistent with the other dependency specifications in this feature. I suspect that the more stringent version requirements specified inside the plug-in will still be picked up by Eclipse's P2? (In reply to Dennis Wagelaar from comment #9) > It's set as "[5.0.1, 7.0)" in the plug-in, but the feature.xml only allows > you to specify a single version with a match rule. Ah! I didn't check the commit target file. feature.xml gives you another option. Don't specify anything. This approach is pursued by UML, QVTo and OCL; no dependencies at all in feature.xml. It would seem that feature.xml dependencies are obsolete wrt P2's analysis of plugins. I guess that a feature.xml dependency might be useful to allow e.g. the MacOS Helios feature to narrow a version range or override an 'optional' or force an OS-specific choice. For the normal boring build I suspect that they are just there to go stale. Anyway +1 for 4.0.1. You might consider stripping feature.xml dependencies for 4.1. New Gerrit change created: https://git.eclipse.org/r/129017 Gerrit change https://git.eclipse.org/r/129017 was merged to [R4_0_maintenance]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=f604dc72b6ec01bfcb0681558bc01135dea6949a I've released 4.0.1M1: https://www.eclipse.org/atl/downloads/#S201810300954 Ed: Can you verify that this works for you? (In reply to Ed Willink from comment #10) > (In reply to Dennis Wagelaar from comment #9) > > It's set as "[5.0.1, 7.0)" in the plug-in, but the feature.xml only allows > > you to specify a single version with a match rule. > > Ah! I didn't check the commit target file. > > feature.xml gives you another option. Don't specify anything. This approach > is pursued by UML, QVTo and OCL; no dependencies at all in feature.xml. > > It would seem that feature.xml dependencies are obsolete wrt P2's analysis > of plugins. I guess that a feature.xml dependency might be useful to allow > e.g. the MacOS Helios feature to narrow a version range or override an > 'optional' or force an OS-specific choice. For the normal boring build I > suspect that they are just there to go stale. > > Anyway +1 for 4.0.1. You might consider stripping feature.xml dependencies > for 4.1. I created bug #540619 for stripping feature.xml dependencies. (In reply to Dennis Wagelaar from comment #13) > I've released 4.0.1M1: https://www.eclipse.org/atl/downloads/#S201810300954 > > Ed: Can you verify that this works for you? A bit late for M1. I'll check that when I create my M2 installations I get no ASM 5. Verified. I can now install ATL using the ASM 6.2.1 provided by the platform. The platform has moved to ASM 7.0 for 2018-12M2. It seems compatible for me so I've just raised my upper version bound to 8 on OCL and QVTd. Please do the same for ATL. New Gerrit change created: https://git.eclipse.org/r/132659 Gerrit change https://git.eclipse.org/r/132659 was merged to [master]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=5524a85cbe93f8c0c75bedc49cad9bb24b1476af New Gerrit change created: https://git.eclipse.org/r/132661 Gerrit change https://git.eclipse.org/r/132661 was merged to [master]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=ba66df460e715caaaaf7f13a0017cbfff6d5c870 New Gerrit change created: https://git.eclipse.org/r/132666 Gerrit change https://git.eclipse.org/r/132666 was merged to [master]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=ce24d257c6621df3c1fa149612ff11856ee9e43e New Gerrit change created: https://git.eclipse.org/r/132674 Gerrit change https://git.eclipse.org/r/132674 was merged to [R4_0_maintenance]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=cbe6c713cb513c96910e8074e71365edaefaaba4 New Gerrit change created: https://git.eclipse.org/r/132675 Gerrit change https://git.eclipse.org/r/132675 was merged to [R4_0_maintenance]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=efb351215693397cdbb2e06b547754592dec8592 New Gerrit change created: https://git.eclipse.org/r/132676 Gerrit change https://git.eclipse.org/r/132676 was merged to [R4_0_maintenance]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=74ad4b2064939908218f88b03c85f35fa3fbbb20 4.0.1M2 released. This has been built against ASM 7.0. New Gerrit change created: https://git.eclipse.org/r/133954 Gerrit change https://git.eclipse.org/r/133954 was merged to [master]. Commit: http://git.eclipse.org/c/mmt/org.eclipse.atl.git/commit/?id=a4111b7cf36696a7b421812178579a0487f9531b 4.0.1 has been released a while back - closing. Please reopen if this bug still exists in 4.0.1! |