Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 534926

Summary:	Remove no-op check of createSplash in Workbench
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	3.7.1
Target Milestone:	4.9
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/123040 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d431d21bc76722962755b8de45d8cfeb537d4b77
Whiteboard:
Bug Depends on:
Bug Blocks:	537715

Description Lars Vogel

2018-05-22 03:41:16 EDT

Line 598 seems unnecessary, I can find no code path which modifies createSplash before this line.

---
if (createSplash) // -> No-op I think
 workbench.createSplashWrapper();
---

Comment 1 Eclipse Genie

2018-05-22 03:42:34 EDT

New Gerrit change created: https://git.eclipse.org/r/123040

Comment 2 Eclipse Genie

2018-05-31 06:11:10 EDT

Gerrit change https://git.eclipse.org/r/123040 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d431d21bc76722962755b8de45d8cfeb537d4b77