Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 534920

Summary:	[Tips] Make sure tips can run on Neon
Product:	[Eclipse Project] Platform	Reporter:	Wim Jongman <wim.jongman>
Component:	User Assistance	Assignee:	Wim Jongman <wim.jongman>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	daniel_megert, Lars.Vogel, mistria
Version:	4.8	Flags:	Lars.Vogel: review+ wim.jongman: review+
Target Milestone:	4.8 RC2
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/123030 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=27a67c51418f533eaa785e3c83ccc200edb88c4d https://git.eclipse.org/r/123206
Whiteboard:
Bug Depends on:
Bug Blocks:	531784

Description Wim Jongman

2018-05-21 13:59:58 EDT

Tips should be able to run on Neon and Oxygen.

Comment 1 Eclipse Genie

2018-05-21 14:02:34 EDT

New Gerrit change created: https://git.eclipse.org/r/123030

Comment 2 Eclipse Genie

2018-05-22 05:17:56 EDT

Gerrit change https://git.eclipse.org/r/123030 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=27a67c51418f533eaa785e3c83ccc200edb88c4d

Comment 3 Eclipse Genie

2018-05-23 14:53:21 EDT

New Gerrit change created: https://git.eclipse.org/r/123206

Comment 4 Mickael Istria

2018-05-24 02:13:20 EDT

This is an enhancement more than a bug. As such it doesn't qualify for addition in RC3 (RC2 is done I believe) and it will have to wait for 4.9.
Also please read carefully the endgame. You're basically not allowed to merge patches without complying with the requested process for RCs.

Comment 5 Wim Jongman

2018-05-24 03:48:00 EDT

(In reply to Mickael Istria from comment #4)
> This is an enhancement more than a bug. As such it doesn't qualify for
> addition in RC3 (RC2 is done I believe) and it will have to wait for 4.9.
> Also please read carefully the endgame. You're basically not allowed to
> merge patches without complying with the requested process for RCs.

The main change is already in. It just caused a warning in Photon which I did not spot while I was making the changes for Neon. It can wait AFAIC.

Comment 6 Mickael Istria

2018-05-24 03:50:58 EDT

(In reply to Wim Jongman from comment #5)
> The main change is already in. It just caused a warning in Photon which I
> did not spot while I was making the changes for Neon. It can wait AFAIC.

Even the former change is not really "legal" according to https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_8.php#FixPassAfterRC1

Comment 7 Wim Jongman

2018-05-24 03:54:54 EDT

(In reply to Mickael Istria from comment #6)
> (In reply to Wim Jongman from comment #5)
> > The main change is already in. It just caused a warning in Photon which I
> > did not spot while I was making the changes for Neon. It can wait AFAIC.
> 
> Even the former change is not really "legal" according to
> https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_8.
> php#FixPassAfterRC1

I see, thanks for the link.

Comment 8 Dani Megert

2018-05-24 05:23:58 EDT

(In reply to Mickael Istria from comment #4)
> This is an enhancement more than a bug. As such it doesn't qualify for
> addition in RC3 (RC2 is done I believe) and it will have to wait for 4.9.
> Also please read carefully the endgame. You're basically not allowed to
> merge patches without complying with the requested process for RCs.

This is a bit of a gray area. We have things like samples and tests in our repository. For those we don't apply the strict process. And since Tips are not part of our build, they could also qualify as such. But I agree, that RC2 is closed and for RC3 only major and well reviewed fixes must go in. That should also be done for Tips, because they actually appear in an EPP.