Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 534611

Summary: Add DOT Attribute support for dir=""
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.0.100 (Photon) M7   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Attachments:
Description Flags
Screenshot displaying the GEF DOT Graph view error message none

Description Tamas Miklossy CLA 2018-05-12 15:56:34 EDT
Created attachment 274017 [details]
Screenshot displaying the GEF DOT Graph view error message

Rendering the following dot file 

digraph {
	A -> B	
	edge[dir=both]
}

within the DOT Graph view results in the following error message:  Could not import DOT: Cannot set edge attribute 'dir' to ''. The value '' is not a syntactically correct dirType.

Although this is not documented explicitly, empty dir attributes seems to be used/supported by the dot language, especially if the dot file is generated by Graphviz.
Comment 1 Tamas Miklossy CLA 2018-05-12 16:21:57 EDT
I pushed the following changes to origin/master:

[534611] Ensure that the DOT Editor/View accepts empty dir values.

- Modify the DotAttributes validateAttributeRawValue method to accept
empty dir attribute values (in these cases no validation on the dir
attribute value take places at all).
- Implement corresponding DotAttributesTests and
DotParserTests test cases.


Resolving as fixed in 5.0.100 (Photon) M7.