Bugzilla – Full Text Bug Listing
|
Description
Wim Jongman
New Gerrit change created: https://git.eclipse.org/r/121815 Gerrit change https://git.eclipse.org/r/121815 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=1889866f88b32b8cb1bd266cdc5859429ca230b4 New Gerrit change created: https://git.eclipse.org/r/121904 Gerrit change https://git.eclipse.org/r/121904 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=165518096041601df2ac603281504e6b479927fd New Gerrit change created: https://git.eclipse.org/r/121905 Gerrit change https://git.eclipse.org/r/121905 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=fb345a81200f2cb7021cdb0d44c1d36d17de3e4b New Gerrit change created: https://git.eclipse.org/r/121906 Gerrit change https://git.eclipse.org/r/121906 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=c7db7152c8d970785efa1381691b3eef23ebce71 New Gerrit change created: https://git.eclipse.org/r/121907 Gerrit change https://git.eclipse.org/r/121907 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=8e77683b36092aab7dc15fef245c84f77b18edf0 New Gerrit change created: https://git.eclipse.org/r/121908 New Gerrit change created: https://git.eclipse.org/r/121913 New Gerrit change created: https://git.eclipse.org/r/121914 Would it be possible to have the tips inside the related *.doc.user bundles? I see many patches were merged without leaving much opportunity for review. In general, it's better to not rush into committing such new content and try to get some feedback before merging it. Note that it's not too important in that case because even if we change it, it doesn't break an API nor change behavior. Gerrit change https://git.eclipse.org/r/121908 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=38dcd21fe5e64c79eea67d86ecb2b624e6d74683 Gerrit change https://git.eclipse.org/r/121913 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=962d921a35471876bf2711902d268aca527f984a (In reply to comment #14) > Would it be possible to have the tips inside the related *.doc.user bundles? Would that not be included in the IDE? > > I see many patches were merged without leaving much opportunity for review. In > general, it's better to not rush into committing such new content and try to > get some feedback before merging it. Note that it's not too important in that > case because even if we change it, it doesn't break an API nor change behavior. Indeed, it is not breaking anything. These are Sopot's tips converted to good looking content. I did not expect someone would want to review this. Gerrit change https://git.eclipse.org/r/121914 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=0042755f51c37aa19cf5f0cfea5259ef71437683 (In reply to Wim Jongman from comment #17) > Would that not be included in the IDE? The provider.json files would be, but I don't think it's what we're discussing when we say "include in IDE or not". What matters is more about whether we include the tips framework in and the dialog by default, but an extra-file in one bundle isn't a too bad thing even if it's not read by default. But I think it's more the topic of bug 534178 so let's keep discussing there. > Indeed, it is not breaking anything. These are Sopot's tips converted to > good looking content. I did not expect someone would want to review this. What we need to review is the whole process of how tips get integrated in the IDE, where they're located, where they're published... I believe this bug actually depends in bug 534178 and a consensual decision of where to store and deploy the tips before starting to actually add tips to the IDE. New Gerrit change created: https://git.eclipse.org/r/121945 Gerrit change https://git.eclipse.org/r/121945 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=dee48561896e7d5b805aff2eec184bea9718b10c Tip content moved to their respective *.doc.user/tipOfTheDay locations (In reply to Eclipse Genie from comment #21) > Gerrit change https://git.eclipse.org/r/121945 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/ > ?id=dee48561896e7d5b805aff2eec184bea9718b10c (In reply to Wim Jongman from comment #22) > Tip content moved to their respective *.doc.user/tipOfTheDay locations Please leave a bit more time for reviews and to allow feedback ;) I didn't realize all the big files involved in the existing tips and I'm now wondering whether the user.doc bundles are the best fit for those. Also, as long as the files are not in build.properties, it means they're basically ignored at build time while they will cause new qualifier for same output. After all, as I see this change, it seems to me that dedicated bundles would be better... New Gerrit change created: https://git.eclipse.org/r/121953 JDT Tip provider was submitted to platform. Please take a look. I wonder how to get build by the way.. New Gerrit change created: https://git.eclipse.org/r/121954 Gerrit change https://git.eclipse.org/r/121953 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=830eb3dca4095f0c7c3cb58ecc91cff10bc4c3fb Created attachment 273884 [details]
HTML Errors
Please take a look at those errors.
(In reply to Dani Megert from comment #28) > Created attachment 273884 [details] > HTML Errors > > Please take a look at those errors. Those are still there. New Gerrit change created: https://git.eclipse.org/r/122354 Gerrit change https://git.eclipse.org/r/122354 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=e9730f84082fac7af44e9d6e2b19dd696a2c87c5 New Gerrit change created: https://git.eclipse.org/r/122441 Gerrit change https://git.eclipse.org/r/122441 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=9dff3286ac3fc7a38e16b160d91e459ce61e6203 New Gerrit change created: https://git.eclipse.org/r/122489 Gerrit change https://git.eclipse.org/r/122489 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=a55daf01ce26bb8ed81fcba845720d7819f0e150 |