Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 533147

Summary: [release] technology.app4mc 0.9.0
Product: Community Reporter: Wayne Beaton <wayne.beaton>
Component: Proposals and ReviewsAssignee: Eclipse Management Organization <emo>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: harald.mackamul, sharon.corbett
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
URL: https://projects.eclipse.org/projects/technology.app4mc/releases/0.9.0
Whiteboard:

Description Wayne Beaton CLA 2018-04-02 16:19:48 EDT
We'll use this bug to track the release

The IP Log is under review.

We require PMC approval of the release and review materials.
Comment 1 Wayne Beaton CLA 2018-04-02 23:39:43 EDT
The IP Log has been approved.
Comment 2 Wayne Beaton CLA 2018-04-04 13:00:45 EDT
PMC Approval: https://dev.eclipse.org/mhonarc/lists/technology-pmc/msg09776.html
Comment 3 Wayne Beaton CLA 2018-04-04 13:10:51 EDT
Harald, I need you to add at least a sentence to describe the release in the release record.

Does the project have any plans to update to the EPL-2.0?

I've noticed that at least one of the about.html files [1] is non-standard.

Why does this deviate from the recommendation [2] ?

[1] http://git.eclipse.org/c/app4mc/org.eclipse.app4mc.git/tree/plugins/org.eclipse.app4mc.amalthea.converters.070/about.html
[2] https://www.eclipse.org/legal/epl/about.php#short-1.0
Comment 4 Wayne Beaton CLA 2018-04-04 16:45:04 EDT
(In reply to Wayne Beaton from comment #3)
> Harald, I need you to add at least a sentence to describe the release in the
> release record.

I see now that you've added some text to the review record. That's a good start.

I'd prefer that you put that description in the release record [1]; can you please expand on that a bit? I don't, for example, know what an "AMALTHEA hardware model" is.

[1] https://projects.eclipse.org/projects/technology.app4mc/releases/0.9.0
Comment 5 Harald Mackamul CLA 2018-04-05 04:10:53 EDT
(In reply to Wayne Beaton from comment #3)

> Does the project have any plans to update to the EPL-2.0?

The main effort for this release was the new hardware model but the update to EPL-2.0 is on our list. Planned time frame is May / June.

> I've noticed that at least one of the about.html files [1] is non-standard.
> 
> Why does this deviate from the recommendation [2] ?
> 
> [1]
> http://git.eclipse.org/c/app4mc/org.eclipse.app4mc.git/tree/plugins/org.
> eclipse.app4mc.amalthea.converters.070/about.html
> [2] https://www.eclipse.org/legal/epl/about.php#short-1.0

Thanks for the hint. The deviation from the recommendation was not intended.
We will correct it.
Comment 6 Harald Mackamul CLA 2018-04-05 05:02:41 EDT
(In reply to Wayne Beaton from comment #3)

> I've noticed that at least one of the about.html files [1] is non-standard.
> 
> Why does this deviate from the recommendation [2] ?

The only difference we found is the following

Recommendation: "The Eclipse Foundation makes available all ..."

Our text: "The Eclipse APP4MC project makes available all ..."
(sometimes "APP4MC provides all ...")

The reason for the deviation is the history of the project. We already published several versions of our code under the EPL before we proposed an official Eclipse project. In that phase the term "Eclipse Foundation" could not be used. During migration to Eclipse we simply replaced the old project name by APP4MC.

Should we change the current texts to the recommended one?
Comment 7 Wayne Beaton CLA 2018-04-05 11:45:02 EDT
(In reply to Harald Mackamul from comment #6)
> Should we change the current texts to the recommended one?

Yes, please.
Comment 8 Wayne Beaton CLA 2018-04-18 14:22:11 EDT
(In reply to Wayne Beaton from comment #7)
> (In reply to Harald Mackamul from comment #6)
> > Should we change the current texts to the recommended one?
> 
> Yes, please.

Did this get addressed?
Comment 9 Harald Mackamul CLA 2018-04-19 00:30:18 EDT
> Did this get addressed?

Yes.

See commit 10 days ago.
http://git.eclipse.org/c/app4mc/org.eclipse.app4mc.git/commit/?h=develop&id=c53470874b27d239132958d0c2876ffbcc503d8d
Comment 10 Wayne Beaton CLA 2018-04-19 10:48:26 EDT
(In reply to Harald Mackamul from comment #9)
> Yes.

Great. Thanks.

I declare this review successful. Please continue with your release.