Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 533138

Summary:	[win32] Specifically target SWT for Windows 8.1 or Windows 10
Product:	[Eclipse Project] Platform	Reporter:	Niraj Modi <niraj.modi>
Component:	SWT	Assignee:	Niraj Modi <niraj.modi>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ned.twigg
Version:	4.8
Target Milestone:	4.8 M7
Hardware:	PC
OS:	Windows 8
See Also:	https://git.eclipse.org/r/120576 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6509033affd4772e7b337e8fb51b322edb474851 https://bugs.eclipse.org/bugs/show_bug.cgi?id=536562
Whiteboard:
Bug Depends on:
Bug Blocks:	480639, 509534, 515502, 517055

Description Niraj Modi

2018-04-02 07:43:05 EDT

As per MSDN, in Windows 8.1 and Windows 10, the GetVersion and GetVersionEx functions have been deprecated:
https://msdn.microsoft.com/en-us/library/windows/desktop/dn481241(v=vs.85).aspx

Below SWT internal API is broken for Win OS version 8.1 and above:
OS.VERSION() and it's returning OS version value equivalent to Windows8.

Updating the javaw.exe.manifest to specifically target SWT for Windows 8.1 or Windows 10 works. Will share a gerrit shortly.

Comment 1 Eclipse Genie

2018-04-02 07:46:14 EDT

New Gerrit change created: https://git.eclipse.org/r/120576

Comment 2 Niraj Modi

2018-04-02 10:02:21 EDT

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/120576

Verified the patch, below check now returns true on Win 10:
OS.WIN32_VERSION == OS.VERSION(10, 0)

Comment 3 Eclipse Genie

2018-04-02 10:03:01 EDT

Gerrit change https://git.eclipse.org/r/120576 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6509033affd4772e7b337e8fb51b322edb474851

Comment 4 Niraj Modi

2018-04-03 06:57:31 EDT

Resolving now.

Comment 5 Niraj Modi

2018-05-09 04:37:07 EDT

Verified in I20180507-2205 on Win10.

Comment 6 Ned Twigg

2018-05-17 14:45:24 EDT

Does this mean SWT no longer supports Windows 7?

Comment 7 Niraj Modi

2018-05-18 02:13:37 EDT

(In reply to Ned Twigg from comment #6)
> Does this mean SWT no longer supports Windows 7?
SWT/Eclipse continue to support Windows7.

This fix is about identifying exact Windows OS version specifically Windows 8.1 and on-wards, for more details please see MSDN article in comment 0