Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 532294

Summary: Update platform to Jetty 9.4.10
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: RelengAssignee: Alexander Kurtakov <akurtakov>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: akurtakov, ctwalker, joakim.erdfelt, mat.booth, nboldt, peter, tjwatson, Vikas.Chandra
Version: 4.8Flags: daniel_megert: pmc_approved+
Target Milestone: 4.8 M7   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/119850
https://git.eclipse.org/r/119851
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=82e36c5f8e3c9072f2450007acc32996f1da4998
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=dbb1e29e74b3ea7bb470e0743885af69fe68d708
https://git.eclipse.org/r/119932
https://git.eclipse.org/r/119933
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=da6922c861fe98241db714e93662e55b460c4628
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=e6363cc7f1335ee3b09fb138d59e943342335837
https://git.eclipse.org/r/119991
https://git.eclipse.org/r/119993
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=01061735b06fdb5723a43a762d9a07f8e4b68dc4
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=409378f02f11af2cd8e03d1f93ad7c0c8a77f2ae
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532775
https://git.eclipse.org/r/120024
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=c6ff81fda5d397d98cba06f15f1e4b1db55b694d
https://git.eclipse.org/r/120025
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=108c5c88b0b66d2fea6e2172b2c38f3d6e974618
https://git.eclipse.org/r/122301
https://git.eclipse.org/r/122302
https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=615d8cca3e8d6c38f64c2e0d29121f03a849a7eb
https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=058fc48121fa9600f94df49079faa70fe7604b2b
https://bugs.eclipse.org/bugs/show_bug.cgi?id=541607
Whiteboard:
Bug Depends on:    
Bug Blocks: 533942    

Description Dani Megert CLA 2018-03-11 13:35:48 EDT
Update platform to latest Jetty 9.4.9.
Comment 1 Dani Megert CLA 2018-03-11 13:36:38 EDT
See jetty-dev for details.

Alex, can you guys handle that?
Comment 3 Alexander Kurtakov CLA 2018-03-16 09:51:05 EDT
Dani, please post when there is p2 repo available at http://download.eclipse.org/jetty/updates/jetty-bundles-9.x/ .
Comment 4 Dani Megert CLA 2018-03-20 09:03:21 EDT
The proposed staged release has been dropped:
https://dev.eclipse.org/mhonarc/lists/jetty-dev/msg03153.html
Comment 5 Dani Megert CLA 2018-03-21 04:38:49 EDT
(In reply to Alexander Kurtakov from comment #3)
> Dani, please post when there is p2 repo available at
> http://download.eclipse.org/jetty/updates/jetty-bundles-9.x/ .

It's there now, see http://dev.eclipse.org/mhonarc/lists/jetty-dev/msg03154.html
Comment 6 Eclipse Genie CLA 2018-03-21 05:22:34 EDT
New Gerrit change created: https://git.eclipse.org/r/119850
Comment 7 Eclipse Genie CLA 2018-03-21 05:23:47 EDT
New Gerrit change created: https://git.eclipse.org/r/119851
Comment 10 Alexander Kurtakov CLA 2018-03-21 05:28:20 EDT
Dani, do you know what this support for Java 10 means and whether it's smth needed for 4.7.3a release?
Comment 11 Alexander Kurtakov CLA 2018-03-21 05:33:24 EDT
Nick, please check whether this is smth WTP plans or needs for Oxygen.3a release as I don't want last minute respin for Jetty again.
Comment 12 Dani Megert CLA 2018-03-21 05:49:56 EDT
(In reply to Alexander Kurtakov from comment #10)
> Dani, do you know what this support for Java 10 means and whether it's smth
> needed for 4.7.3a release?

Not more than what was in the mailing list message. It lists this item:
Â+ 2358 Add ALPN module file for JDK 10

I think we should include this in 4.7.3a.
Comment 13 Dani Megert CLA 2018-03-21 05:53:53 EDT
(In reply to Dani Megert from comment #12)
> (In reply to Alexander Kurtakov from comment #10)
> > Dani, do you know what this support for Java 10 means and whether it's smth
> > needed for 4.7.3a release?
> 
> Not more than what was in the mailing list message. It lists this item:
> Â+ 2358 Add ALPN module file for JDK 10
> 
> I think we should include this in 4.7.3a.

Looking through things, I think it is to allow running Jetty with Java 10, so, definitely something we want in 4.7.3a.
Comment 15 Eclipse Genie CLA 2018-03-22 03:04:26 EDT
New Gerrit change created: https://git.eclipse.org/r/119932
Comment 16 Eclipse Genie CLA 2018-03-22 03:06:38 EDT
New Gerrit change created: https://git.eclipse.org/r/119933
Comment 19 Dani Megert CLA 2018-03-22 05:44:12 EDT
This might not indicate a real problem but someone should verify. We get a warning from API Tools Verification Reports:

http://download.eclipse.org/eclipse/downloads/drops4/I20180322-0225/apitools/analysis/html/index.html

Adding Vikas from PDE.
Comment 20 Dani Megert CLA 2018-03-22 10:50:46 EDT
Sorry, but at least starting the IDE and testing Help seems like the least thing to do before putting it in.

1. Download http://download.eclipse.org/eclipse/downloads/drops4/I20180322-0645/
2. Start with new workspace
==>

!ENTRY org.eclipse.equinox.http.jetty 4 0 2018-03-22 15:48:13.869
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.equinox.http.jetty [126]
  Unresolved requirement: Import-Package: org.eclipse.jetty.server; version="[9.4.0,10.0.0)"
    -> Export-Package: org.eclipse.jetty.server; bundle-symbolic-name="org.eclipse.jetty.server"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.net.ssl,javax.security.auth,javax.servlet,javax.servlet.http,org.eclipse.jetty.http,org.eclipse.jetty.io,org.eclipse.jetty.io.ssl,org.eclipse.jetty.server.handler,org.eclipse.jetty.server.session,org.eclipse.jetty.util,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource,org.eclipse.jetty.util.ssl,org.eclipse.jetty.util.thread"
       org.eclipse.jetty.server [200]
         Unresolved requirement: Import-Package: org.eclipse.jetty.http; version="[9.4.9,9.4.10)"
           -> Export-Package: org.eclipse.jetty.http; bundle-symbolic-name="org.eclipse.jetty.http"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="org.eclipse.jetty.io,org.eclipse.jetty.util,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource"
              org.eclipse.jetty.http [197]
                Unresolved requirement: Import-Package: org.eclipse.jetty.util; version="[9.4.9,9.4.10)"
                  -> Export-Package: org.eclipse.jetty.util; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.servlet,javax.servlet.http,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource,org.eclipse.jetty.util.thread"
                     org.eclipse.jetty.util [202]
                       Unresolved requirement: Require-Capability: osgi.serviceloader; filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.CredentialProvider)"; resolution:="optional"; cardinality:="multiple"
                       Unresolved requirement: Require-Capability: osgi.extender; filter:="(osgi.extender=osgi.serviceloader.processor)"
                Unresolved requirement: Import-Package: org.eclipse.jetty.io; version="[9.4.9,9.4.10)"
                  -> Export-Package: org.eclipse.jetty.io; bundle-symbolic-name="org.eclipse.jetty.io"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.net.ssl,org.eclipse.jetty.util,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.thread"
                     org.eclipse.jetty.io [198]
                       Unresolved requirement: Import-Package: org.eclipse.jetty.util; version="[9.4.9,9.4.10)"
                         -> Export-Package: org.eclipse.jetty.util; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.servlet,javax.servlet.http,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource,org.eclipse.jetty.util.thread"
                       Unresolved requirement: Import-Package: org.eclipse.jetty.util.annotation; version="[9.4.9,9.4.10)"
                         -> Export-Package: org.eclipse.jetty.util.annotation; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"
  Unresolved requirement: Import-Package: org.eclipse.jetty.server.handler; version="[9.4.0,10.0.0)"
    -> Export-Package: org.eclipse.jetty.server.handler; bundle-symbolic-name="org.eclipse.jetty.server"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.servlet,javax.servlet.descriptor,javax.servlet.http,org.eclipse.jetty.http,org.eclipse.jetty.io,org.eclipse.jetty.server,org.eclipse.jetty.util,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource"
  Unresolved requirement: Import-Package: org.eclipse.jetty.http; version="[9.4.0,10.0.0)"
    -> Export-Package: org.eclipse.jetty.http; bundle-symbolic-name="org.eclipse.jetty.http"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="org.eclipse.jetty.io,org.eclipse.jetty.util,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource"

	at org.eclipse.osgi.container.Module.start(Module.java:444)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1661)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY org.eclipse.jgit.pgm 4 0 2018-03-22 15:48:13.873
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.jgit.pgm [211]
  Unresolved requirement: Import-Package: org.eclipse.jetty.io; version="[9.4.5,10.0.0)"
    -> Export-Package: org.eclipse.jetty.io; bundle-symbolic-name="org.eclipse.jetty.io"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.net.ssl,org.eclipse.jetty.util,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.thread"
       org.eclipse.jetty.io [198]
         Unresolved requirement: Import-Package: org.eclipse.jetty.util; version="[9.4.9,9.4.10)"
           -> Export-Package: org.eclipse.jetty.util; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.servlet,javax.servlet.http,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource,org.eclipse.jetty.util.thread"
              org.eclipse.jetty.util [202]
                Unresolved requirement: Require-Capability: osgi.serviceloader; filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.CredentialProvider)"; resolution:="optional"; cardinality:="multiple"
                Unresolved requirement: Require-Capability: osgi.extender; filter:="(osgi.extender=osgi.serviceloader.processor)"
         Unresolved requirement: Import-Package: org.eclipse.jetty.util.annotation; version="[9.4.9,9.4.10)"
           -> Export-Package: org.eclipse.jetty.util.annotation; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"
  Unresolved requirement: Import-Package: org.eclipse.jetty.http; version="[9.4.5,10.0.0)"
    -> Export-Package: org.eclipse.jetty.http; bundle-symbolic-name="org.eclipse.jetty.http"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="org.eclipse.jetty.io,org.eclipse.jetty.util,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource"
       org.eclipse.jetty.http [197]
         Unresolved requirement: Import-Package: org.eclipse.jetty.util; version="[9.4.9,9.4.10)"
           -> Export-Package: org.eclipse.jetty.util; bundle-symbolic-name="org.eclipse.jetty.util"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.servlet,javax.servlet.http,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.resource,org.eclipse.jetty.util.thread"
         Unresolved requirement: Import-Package: org.eclipse.jetty.io; version="[9.4.9,9.4.10)"
           -> Export-Package: org.eclipse.jetty.io; bundle-symbolic-name="org.eclipse.jetty.io"; bundle-version="9.4.9.v20180320"; version="9.4.9"; uses:="javax.net.ssl,org.eclipse.jetty.util,org.eclipse.jetty.util.annotation,org.eclipse.jetty.util.component,org.eclipse.jetty.util.log,org.eclipse.jetty.util.thread"

	at org.eclipse.osgi.container.Module.start(Module.java:444)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1661)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)


3. Window > Help Contents
==>

!ENTRY org.eclipse.ui 4 0 2018-03-22 15:50:06.159
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NoClassDefFoundError: org/eclipse/equinox/http/jetty/JettyConfigurator
	at org.eclipse.help.internal.server.JettyHelpServer$StartServerThread.run(JettyHelpServer.java:79)
Caused by: java.lang.ClassNotFoundException: org.eclipse.equinox.http.jetty.JettyConfigurator cannot be found by org.eclipse.help.base_4.2.200.v20180322-0645
	at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:508)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:419)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:411)
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:150)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
	... 1 more
Comment 21 Dani Megert CLA 2018-03-22 11:02:14 EDT
Git is also affected:

org.osgi.framework.BundleException: Could not resolve module: org.eclipse.jgit.pgm [211]
Comment 22 Alexander Kurtakov CLA 2018-03-22 11:05:34 EDT
Sigh, I tried. Obviously not the correct dir. Will revert ASAP.
Comment 23 Eclipse Genie CLA 2018-03-22 11:08:26 EDT
New Gerrit change created: https://git.eclipse.org/r/119991
Comment 24 Eclipse Genie CLA 2018-03-22 11:10:52 EDT
New Gerrit change created: https://git.eclipse.org/r/119993
Comment 27 Alexander Kurtakov CLA 2018-03-22 11:37:43 EDT
OSGI diag of jetty.utils:
org.eclipse.jetty.util [1218]
  Unresolved requirement: Require-Capability: osgi.serviceloader; filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.CredentialProvider)"; resolution:="optional"; cardinality:="multiple"
  Unresolved requirement: Require-Capability: osgi.extender; filter:="(osgi.extender=osgi.serviceloader.processor)"
Comment 28 Thomas Watson CLA 2018-03-22 11:41:49 EDT
(In reply to Alexander Kurtakov from comment #27)
> OSGI diag of jetty.utils:
> org.eclipse.jetty.util [1218]
>   Unresolved requirement: Require-Capability: osgi.serviceloader;
> filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.
> CredentialProvider)"; resolution:="optional"; cardinality:="multiple"

This is an optional requirement, it shows up in diag as an unresolve requirement, but that is fine because it is optional


>   Unresolved requirement: Require-Capability: osgi.extender;
> filter:="(osgi.extender=osgi.serviceloader.processor)"

I thought we had requested jetty to make this requirement optional in past versions, did become non-optional again?
Comment 29 Alexander Kurtakov CLA 2018-03-22 11:48:09 EDT
(In reply to Thomas Watson from comment #28)
> (In reply to Alexander Kurtakov from comment #27)
> > OSGI diag of jetty.utils:
> > org.eclipse.jetty.util [1218]
> >   Unresolved requirement: Require-Capability: osgi.serviceloader;
> > filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.
> > CredentialProvider)"; resolution:="optional"; cardinality:="multiple"
> 
> This is an optional requirement, it shows up in diag as an unresolve
> requirement, but that is fine because it is optional
> 
> 
> >   Unresolved requirement: Require-Capability: osgi.extender;
> > filter:="(osgi.extender=osgi.serviceloader.processor)"
> 
> I thought we had requested jetty to make this requirement optional in past
> versions, did become non-optional again?

It's yet another bundle I think.
 Commented on upstream https://github.com/eclipse/jetty.project/issues/2164 requesting the same fix to make it optional.
What is the story with osgi.serviceloader.processor ? Is there anything in felix/equionx providing it? Any plans to be included in equinox?
Comment 30 Thomas Watson CLA 2018-03-22 11:49:41 EDT
(In reply to Alexander Kurtakov from comment #29)
> (In reply to Thomas Watson from comment #28)
> > (In reply to Alexander Kurtakov from comment #27)
> > > OSGI diag of jetty.utils:
> > > org.eclipse.jetty.util [1218]
> > >   Unresolved requirement: Require-Capability: osgi.serviceloader;
> > > filter:="(osgi.serviceloader=org.eclipse.jetty.util.security.
> > > CredentialProvider)"; resolution:="optional"; cardinality:="multiple"
> > 
> > This is an optional requirement, it shows up in diag as an unresolve
> > requirement, but that is fine because it is optional
> > 
> > 
> > >   Unresolved requirement: Require-Capability: osgi.extender;
> > > filter:="(osgi.extender=osgi.serviceloader.processor)"
> > 
> > I thought we had requested jetty to make this requirement optional in past
> > versions, did become non-optional again?
> 
> It's yet another bundle I think.
>  Commented on upstream https://github.com/eclipse/jetty.project/issues/2164
> requesting the same fix to make it optional.
> What is the story with osgi.serviceloader.processor ? Is there anything in
> felix/equionx providing it? Any plans to be included in equinox?

There is no plans to provide the service loader implementation in equinox.  I also would not want to pull in anything from apache aries to provide this.  I believe it really should be made an optional requirement here.
Comment 31 Eclipse Genie CLA 2018-03-22 18:26:53 EDT
New Gerrit change created: https://git.eclipse.org/r/120024
Comment 33 Eclipse Genie CLA 2018-03-22 18:29:08 EDT
New Gerrit change created: https://git.eclipse.org/r/120025
Comment 35 Dani Megert CLA 2018-03-23 06:31:15 EDT
Alex or Tom, are you talking to the Jetty guys? It would be good to have it for 4.7.3a, as it allows to use Jetty with Java 10.
Comment 36 Alexander Kurtakov CLA 2018-03-23 07:23:02 EDT
(In reply to Dani Megert from comment #35)
> Alex or Tom, are you talking to the Jetty guys? It would be good to have it
> for 4.7.3a, as it allows to use Jetty with Java 10.

I am as per comment 29 .
Comment 37 Mat Booth CLA 2018-03-23 12:39:52 EDT
I submitted a PR upstream: https://github.com/eclipse/jetty.project/pull/2377
Comment 38 Joakim Erdfelt CLA 2018-03-23 13:04:43 EDT
(In reply to Thomas Watson from comment #30)
> (In reply to Alexander Kurtakov from comment #29)
> > (In reply to Thomas Watson from comment #28)
> > ....
> > What is the story with osgi.serviceloader.processor ? Is there anything in
> > felix/equionx providing it? Any plans to be included in equinox?
> 
> There is no plans to provide the service loader implementation in equinox. 
> I also would not want to pull in anything from apache aries to provide this.
> I believe it really should be made an optional requirement here.

Is there an open bug for adding osgi.serviceloader.processor into equinox
that we can flag/monitor?

ServiceLoader use is growing, more and more rapidly with each year.
Jetty 10.x will have even more uses of it (courtesy of both Java 11 and
Servlet 4.0 requirements).  So we should start getting ready for a future
where its no longer optional.
Comment 39 Alexander Kurtakov CLA 2018-03-23 13:08:50 EDT
(In reply to Joakim Erdfelt from comment #38)
> (In reply to Thomas Watson from comment #30)
> > (In reply to Alexander Kurtakov from comment #29)
> > > (In reply to Thomas Watson from comment #28)
> > > ....
> > > What is the story with osgi.serviceloader.processor ? Is there anything in
> > > felix/equionx providing it? Any plans to be included in equinox?
> > 
> > There is no plans to provide the service loader implementation in equinox. 
> > I also would not want to pull in anything from apache aries to provide this.
> > I believe it really should be made an optional requirement here.
> 
> Is there an open bug for adding osgi.serviceloader.processor into equinox
> that we can flag/monitor?
> 
> ServiceLoader use is growing, more and more rapidly with each year.
> Jetty 10.x will have even more uses of it (courtesy of both Java 11 and
> Servlet 4.0 requirements).  So we should start getting ready for a future
> where its no longer optional.

Tom is equinox lead and so far there doesn't seem to be any such plans according to him in comment 30.
Comment 40 Nick Boldt CLA 2018-04-19 08:57:00 EDT
Just curious when this change will appear in the http://download.eclipse.org/staging/photon/ repo... it'd be nice to be able to test this out prior to M7. Thanks!
Comment 41 Alexander Kurtakov CLA 2018-04-20 02:26:58 EDT
9.4.9 is not usable from Platform POV. Once 9.4.10 is released assuming it doesn't contain any other such breaking changes it shouldn't be long. But it's smth that doesn't depend on us.
Comment 42 Nick Boldt CLA 2018-05-02 09:24:24 EDT
(09:20:51 AM) akurtakov: there is jetty 9.4.10 rc
(09:21:02 AM) akurtakov: https://github.com/eclipse/jetty.project/releases/

(09:21:11 AM) akurtakov: but when will it be final I have no idea
(09:21:35 AM) akurtakov: so if they make it this or early next week I'll try to put it in in M7

(09:21:59 AM) akurtakov: but until then platform will stay on 9.4.8 for M7 

(09:22:11 AM) akurtakov: but I definitely want to move on for Photon
(09:22:16 AM) akurtakov: even if it's RCx content

(09:21:45 AM) nboldt: :thumbsup:
Comment 43 Joakim Erdfelt CLA 2018-05-02 10:47:59 EDT
2 weeks (tops)  Stay tuned.  The Eclipse Jetty Committers are having a meeting today to discuss it.
Comment 44 Joakim Erdfelt CLA 2018-05-02 10:48:48 EDT
In the meantime, can you test 9.4.10.RC1 and see if it addresses this bug/issue?
Comment 45 Alexander Kurtakov CLA 2018-05-02 10:51:08 EDT
(In reply to Joakim Erdfelt from comment #44)
> In the meantime, can you test 9.4.10.RC1 and see if it addresses this
> bug/issue?

Do you have a p2 repo for RC1?
Comment 46 Christopher Walker CLA 2018-05-02 11:40:17 EDT
A P2 repo for 9.4.10.RC1 is available via: http://download.eclipse.org/jetty/updates/jetty-bundles-9.x
Comment 47 Alexander Kurtakov CLA 2018-05-02 13:24:01 EDT
(In reply to Christopher Walker from comment #46)
> A P2 repo for 9.4.10.RC1 is available via:
> http://download.eclipse.org/jetty/updates/jetty-bundles-9.x

Platform built just fine using jetty from http://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.10.RC1/ and Help system is functional. So I consider this one good for us.
Comment 48 Christopher Walker CLA 2018-05-06 22:08:06 EDT
(In reply to Alexander Kurtakov from comment #47)
> (In reply to Christopher Walker from comment #46)
> > A P2 repo for 9.4.10.RC1 is available via:
> > http://download.eclipse.org/jetty/updates/jetty-bundles-9.x
> 
> Platform built just fine using jetty from
> http://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.10.RC1/ and
> Help system is functional. So I consider this one good for us.

The final release of 9.4.10 is now available at the same P2 repo:  http://download.eclipse.org/jetty/updates/jetty-bundles-9.x
Comment 49 Eclipse Genie CLA 2018-05-08 07:20:24 EDT
New Gerrit change created: https://git.eclipse.org/r/122301
Comment 50 Eclipse Genie CLA 2018-05-08 07:21:37 EDT
New Gerrit change created: https://git.eclipse.org/r/122302
Comment 53 Alexander Kurtakov CLA 2018-05-08 10:07:59 EDT
In latest build now and help system functions just fine.
Comment 54 Dani Megert CLA 2018-05-09 03:53:35 EDT
(In reply to Alexander Kurtakov from comment #53)
> In latest build now and help system functions just fine.

How about other clients?

http://download.eclipse.org/eclipse/downloads/drops4/I20180508-2000/apitools/freeze_report.html

lists quite a few removals.
Comment 55 Alexander Kurtakov CLA 2018-05-09 04:08:17 EDT
(In reply to Dani Megert from comment #54)
> (In reply to Alexander Kurtakov from comment #53)
> > In latest build now and help system functions just fine.
> 
> How about other clients?
> 
> http://download.eclipse.org/eclipse/downloads/drops4/I20180508-2000/apitools/
> freeze_report.html
> 
> lists quite a few removals.

There isn't anythin we can do about this. Staying on old Jetty is not an option as on the next CVE we will move anyway so other clients will have to migrate. Practically speaking the only component I know relying on Jetty coming through platform is WTP and Nick is going to do the move for M7.
Comment 56 Dani Megert CLA 2018-05-09 04:17:17 EDT
(In reply to Alexander Kurtakov from comment #55)
> There isn't anythin we can do about this. Staying on old Jetty is not an
> option as on the next CVE we will move anyway so other clients will have to
> migrate.

You could send a note to cross-project listing the changes.

I've added the API change approval to the exclude list with http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=2b2a1f72b9620ccb95c9f8d47d2cababe4fa0404
Comment 57 Alexander Kurtakov CLA 2018-05-09 04:30:11 EDT
(In reply to Dani Megert from comment #56)
> (In reply to Alexander Kurtakov from comment #55)
> > There isn't anythin we can do about this. Staying on old Jetty is not an
> > option as on the next CVE we will move anyway so other clients will have to
> > migrate.
> 
> You could send a note to cross-project listing the changes.

Done.
> 
> I've added the API change approval to the exclude list with
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=2b2a1f72b9620ccb95c9f8d47d2cababe4fa0404