Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 531968

Summary:	Mark Job.createSystem(ICoreRunnable) API for deletion
Product:	[Eclipse Project] Platform	Reporter:	Andrey Loskutov <loskutov>
Component:	Runtime	Assignee:	Andrey Loskutov <loskutov>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, gautier.desaintmartinlacaze, Lars.Vogel
Version:	4.8
Target Milestone:	4.11 M3
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=531276 https://git.eclipse.org/r/137192 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=433c70e9603e2e9ab7ebdaf229352a608ff8c219 https://bugs.eclipse.org/bugs/show_bug.cgi?id=544573
Whiteboard:
Bug Depends on:
Bug Blocks:	544573

Description Andrey Loskutov

2018-03-04 03:53:51 EST

Follow up on Bug 531276, we should delete Job.createSystem(ICoreRunnable) API in 4.10.

@Dani: can you please add 4.9, 4.10 etc bugzilla targets for Platform?

Note: according to https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process, we have to wait 2 years after the announcement. Should this be updated now (with the faster release cycles after 4.8), or is this still valid?

Comment 1 Lars Vogel

2018-09-25 16:03:04 EDT

(In reply to Andrey Loskutov from comment #0)

> Note: according to
> https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process, we have to
> wait 2 years after the announcement. Should this be updated now (with the
> faster release cycles after 4.8), or is this still valid?

So far still valid

Comment 2 Lars Vogel

2019-02-19 03:32:39 EST

Mass change, please reset target if you still planning to fix this for 4.11.

Comment 3 Lars Vogel

2019-02-19 04:40:49 EST

Andrey, can you finish the mark for deletion for 4.11?

Comment 4 Andrey Loskutov

2019-02-19 04:47:52 EST

(In reply to Lars Vogel from comment #3)
> Andrey, can you finish the mark for deletion for 4.11?

4.11? What is about comment 1 saying we have to wait 2 years?

Comment 5 Lars Vogel

2019-02-19 05:05:33 EST

(In reply to Andrey Loskutov from comment #4)
> (In reply to Lars Vogel from comment #3)
> > Andrey, can you finish the mark for deletion for 4.11?
> 
> 4.11? What is about comment 1 saying we have to wait 2 years?

We have to mark it for deletion and afterwards wait for 2 years. So you need to add the fitting annotations to the method, send an email to cross and add an entry to the porting guide. See
https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process, especially
point 5.

I can help with the porting guide.

Comment 6 Andrey Loskutov

2019-02-19 05:11:42 EST

(In reply to Lars Vogel from comment #5)
> (In reply to Andrey Loskutov from comment #4)
> > (In reply to Lars Vogel from comment #3)
> > > Andrey, can you finish the mark for deletion for 4.11?
> > 
> > 4.11? What is about comment 1 saying we have to wait 2 years?
> 
> We have to mark it for deletion and afterwards wait for 2 years. So you need
> to add the fitting annotations to the method, send an email to cross 

Was already done in bug 531276.

> and add
> an entry to the porting guide. See
> https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process, especially
> point 5.
> 
> I can help with the porting guide.

I've missed this, if you can, please do whatever is needed here.

Comment 7 Lars Vogel

2019-02-19 05:56:24 EST

(In reply to Andrey Loskutov from comment #6)
> I've missed this, if you can, please do whatever is needed here.

Ok, email send to cross. Docu Gerrit upcoming.

Comment 8 Eclipse Genie

2019-02-19 05:58:47 EST

New Gerrit change created: https://git.eclipse.org/r/137192

Comment 9 Eclipse Genie

2019-02-19 06:01:42 EST

Gerrit change https://git.eclipse.org/r/137192 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=433c70e9603e2e9ab7ebdaf229352a608ff8c219

Comment 10 Andrey Loskutov

2019-02-19 06:53:55 EST

(In reply to Lars Vogel from comment #7)
> (In reply to Andrey Loskutov from comment #6)
> > I've missed this, if you can, please do whatever is needed here.
> 
> Ok, email send to cross.

Lars, this was *already* done on bug 531276.

> Docu Gerrit upcoming.

I've only missed this porting guide, and the change should go to bug 531276.

*This* bug was about actual *deletion*, not "marking for", which is bug 531276.

I will now create a third bug to delete that code.

Comment 11 Lars Vogel

2019-02-19 06:57:04 EST

(In reply to Andrey Loskutov from comment #10)
> (In reply to Lars Vogel from comment #7)
> > (In reply to Andrey Loskutov from comment #6)
> > > I've missed this, if you can, please do whatever is needed here.
> > 
> > Ok, email send to cross.
> 
> Lars, this was *already* done on bug 531276.
> 
> > Docu Gerrit upcoming.
> 
> I've only missed this porting guide, and the change should go to bug 531276.

Next time please do the mark for deletion work completely to avoid such duplication of work and confusion.

> I will now create a third bug to delete that code.

We usually don't do this, no use to have a bug hanging around for 2 years. Just wait and open this bug in two years. I typically check the migration guide to see what can be deleted.

Comment 12 Andrey Loskutov

2019-02-19 07:01:29 EST

I've created bug 544573.