Bugzilla – Full Text Bug Listing
| Summary: | [Dark Theme] White background of icon decorators in Java Outline renders them unreadable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Lars Vogel <Lars.Vogel> | ||||||||
| Component: | UI | Assignee: | JDT-UI-Inbox <jdt-ui-inbox> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | Lars.Vogel, ma.becker, stephan.herrmann | ||||||||
| Version: | 4.7 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | stalebug | ||||||||||
| Attachments: |
|
||||||||||
(In reply to Lars Vogel from comment #0) > I suggest to remove it. You don't propose to remove them completely, do you??? (In reply to Stephan Herrmann from comment #1) > You don't propose to remove them completely, do you??? Quote: "due to the white background. I suggest to remove it." It should refer to "the white background". Removing the white keyline might be tricky. It is there so that the overlay clearly separated from the model object that it is layed over. The Eclipse User Interface Guideline as https://wiki.eclipse.org/User_Interface_Guidelines says in chapter "Object Overlay (and Underlay)": "Overlay icons should have an outer white keyline surrounding the image to clearly separate them from the model object icons that they over lay. If there is not enough space to add the white keyline all the way around the overlay image, then add the white pixels on only the side that will be overlapping the model object." Created attachment 272925 [details]
Outline in dark theme
See the final static class. There the "S" really is on top of the class icon. When we remove the white keyline readability might get worse.
Created attachment 272926 [details]
Outline in light theme
Also in the light theme you see the white keyline in places where the overlay overlaps the model icon.
We can try how these look like without the white keyline. But this needs good testing, because there is quite a combination of model-icons (class, interface, public method, private method, ...) and overlays (static, final, ...). Annother option is to give the keyline transparency to it will look grey in the dark theme which might not be so distracting. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
Created attachment 272915 [details] Screenshot If you look at the icon decorators (SF) in the dark theme, they are not readable due to the white background. I suggest to remove it.