| Summary: | [Generic TP Editor] typo in Edit Software Site view when launched from TP editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Nick Boldt <nboldt> | ||||
| Component: | SWT | Assignee: | Eric Williams <ericwill> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Eric Williams <ericwill> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | akurtakov, ericwill, lbullen, sewe, Vikas.Chandra | ||||
| Version: | 4.8 | ||||||
| Target Milestone: | 4.8 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/119586 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8c8ba9af9f98118ac41a3aace8a8fc570bbcd1e0 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 528707 | ||||||
| Bug Blocks: | 531600, 531603 | ||||||
| Attachments: |
|
||||||
Can you attach the snap? New Gerrit change created: https://git.eclipse.org/r/118052 Created attachment 272857 [details]
Screenshot
SWT issue in GTK3.20+ computeSize returns a smaller than ideal width. (In reply to Alexander Kurtakov from comment #4) > SWT issue in GTK3.20+ computeSize returns a smaller than ideal width. I'll investigate. Looks like the bug actually happens somewhere between GTK3.20 and 3.22. 3.20.10 doesn't have the bug. The GTK commit that caused this bug: https://github.com/GNOME/gtk/commit/5ccc0e40f5eaa9c0e2121674913c398e9963f0be Ironically, this is a commit which fixed bug 494183. I'll continue to investigate. Maybe it's time to give up on gtk_widget_override_font and move it to css ? (In reply to Alexander Kurtakov from comment #8) > Maybe it's time to give up on gtk_widget_override_font and move it to css ? IIRC the time involved with that was pretty high, not sure if it's worth it for 4.8. For this bug I've discovered it only happens when doing: button.setFont(parent.getFont()); It's possible the pango font size is wrong and just needs to be adjusted -- I'm trying that approach out now. New Gerrit change created: https://git.eclipse.org/r/119586 Gerrit change https://git.eclipse.org/r/119586 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8c8ba9af9f98118ac41a3aace8a8fc570bbcd1e0 (In reply to Eclipse Genie from comment #11) > Gerrit change https://git.eclipse.org/r/119586 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=8c8ba9af9f98118ac41a3aace8a8fc570bbcd1e0 Fix is in master now. *** Bug 532810 has been marked as a duplicate of this bug. *** Verified in I20180507-2205. |
Fired up Eclipse from this build [1]. Imported this project [2]. Opened this file [3]. Result is a messy TP editor, with seemingly none of my IUs loaded. So I double-clicked one of the URLs listed on the Definition tab, and a new view was launched. On that view there's a checkbox which reads: "Show only the latest versio". ^^ [1] https://ci.eclipse.org/packaging/job/photon.epp-tycho-build/129/artifact/org.eclipse.epp.packages/archive/ [2] https://github.com/jbosstools/jbosstools-target-platforms/tree/f16997b32cb08222a2705417d79e67a8e25cb94c/jbosstools/multiple [3] https://github.com/jbosstools/jbosstools-target-platforms/blob/f16997b32cb08222a2705417d79e67a8e25cb94c/jbosstools/multiple/jbosstools-multiple.target