Bugzilla – Full Text Bug Listing
| Summary: | [dark] Git decorator generates hard-to-read entries for ignored resources | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Robert Munteanu <robert.munteanu> | ||||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | chidveer, Lars.Vogel, matthias.sohn, twolf | ||||||
| Version: | 4.10 | ||||||||
| Target Milestone: | 4.11 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/117985 https://git.eclipse.org/c/egit/egit.git/commit/?id=502bbd9af6078180377c8f9c7f0f6e6284d622fb |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Robert Munteanu
Created attachment 272810 [details]
Package explorer with decorator enabled
Created attachment 272811 [details]
Package explorer with decorator disabled
Duplicate of bug 496585? @Lars: wasn't there another bug somewhere, originally in EGit but now possibly in Platform, about these plugin's overrides/additions of workbench CSS not always working? I'm sure I had seen that a while ago, but I can't find it now. Found it; that was bug 466075. Looks like the upshot is that we have to add a pseudo-selector? @Lars: is that correct? And the EGit bug report I was thinking of was bug 502380. Thomas, IIRC we added the pseudo selector to the Egit styling. I don't see it in org.eclipse.egit.ui/css/e4-dark_egit_prefstyle.css ? Shouldn't there be a trailing ":org-eclipse-egit-ui" ? (In reply to Thomas Wolf from comment #7) > I don't see it in org.eclipse.egit.ui/css/e4-dark_egit_prefstyle.css ? > Shouldn't there be a trailing ":org-eclipse-egit-ui" ? Yes. I very sure ai contributed that. Not at my computer though to verify. (In reply to Lars Vogel from comment #8) > (In reply to Thomas Wolf from comment #7) > > I don't see it in org.eclipse.egit.ui/css/e4-dark_egit_prefstyle.css ? > > Shouldn't there be a trailing ":org-eclipse-egit-ui" ? > > Yes. I very sure ai contributed that. Not at my computer though to verify. Anyway, I suggest to add it, if it is now missing. It will only do good. New Gerrit change created: https://git.eclipse.org/r/117985 Gerrit change https://git.eclipse.org/r/117985 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=502bbd9af6078180377c8f9c7f0f6e6284d622fb Wow, thanks for the quick fix. You're welcome. Actually, both Lars and I thought this had been done long ago. But apparently the CSS update had fallen through the cracks after bug 466075 had been fixed :-( Anyway, the fix is available in the latest EGit nightly from http://download.eclipse.org/egit/updates-nightly, and it'll be in the soon to be released 4.11, too. (In reply to Thomas Wolf from comment #13) > You're welcome. Actually, both Lars and I thought this had been done long > ago. Looks like I only fixed the definition in platform, so this was fixed for me as EGit was not using the same CSS node as platform (due to the pseudo selector). I assume Robert has something else installed which also does not use the pseudo selector. Robert, if you find another css extension without the selector, please open a bug for the corresponding component. (In reply to comment #14) > (In reply to Thomas Wolf from comment #13) > > You're welcome. Actually, both Lars and I thought this had been done long > > ago. > > Looks like I only fixed the definition in platform, so this was fixed for me as > EGit was not using the same CSS node as platform (due to the pseudo selector). I > assume Robert has something else installed which also does not use the pseudo > selector. Robert, if you find another css extension without the selector, please > open a bug for the corresponding component. Will open another bug if I see a problem, of course. *** Bug 533561 has been marked as a duplicate of this bug. *** |