Bugzilla – Full Text Bug Listing
| Summary: | Incorrect view placement in debug perspective (Photon) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | Daniel Wille <dwille> | ||||
| Component: | Terminal | Assignee: | dsdp.tm.core-inbox <tm.core-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | eclipse | ||||
| Version: | 4.4 | ||||||
| Target Milestone: | 4.4 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/119217 https://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/commit/?id=121bc1f3ea828cf625634b25221ca1a8b3c73574 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 464898 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Daniel Wille
Thanks for the report, and the contribution! We'll need to be a bit careful with changing the "base view" that the Terminal is relative to, in order to avoid issues in other perspectives (where TaskList would exist but ConsoleView would not). So first of all, I am wondering which change in Photon triggered the different behavior that you observe now. I could not find anything relevant in platform.debug.ui , do you have an idea where the relevant Photon change might be? Here is maybe a pointer: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464898#c8 OK, so it looks like the change in fact came in through bug 464898 in Photon M4, see https://www.eclipse.org/eclipse/news/4.8/M4/#debug-perspective-changed But I couldn't find a relevant commit in either debug.ui (which defines the debug perspective): https://git.eclipse.org/c/gerrit/platform/eclipse.platform.debug.git/tree/org.eclipse.debug.ui/plugin.xml or platform.ui (which defines the TasksList view): https://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.ide/plugin.xml I'll ask on bug 464898 for committers of the original Photon change to help... Yeah, I assumed this was due to the debug perspective having its layout changed, and I’m assuming the task list view used to be there by default. I wasn’t sure which other view it should be relative to, which is why I looked up what the PDE log view does. I suppose a few others could be checked to see what others are using. Hi Daniel, I have double-checked that the "Console" view has already been in the Debug perspective in Eclipse 3.8, so I am good applying your patch unmodified - I think it's the best solution. Unfortunately, I cannot commit the patch while preserving your Author information in Git (Eclipse servers disallow this). Could you, ideally, make your contribution through Gerrit? https://wiki.eclipse.org/Gerrit TIA, Martin New Gerrit change created: https://git.eclipse.org/r/119217 Gerrit change https://git.eclipse.org/r/119217 was merged to [master]. Commit: http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/commit/?id=121bc1f3ea828cf625634b25221ca1a8b3c73574 Resolved for 4.4 (Photon). |