Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 531277

Summary:	Update webtools.sourceediting/xml/bundles/org.eclipse.wst.xsd.ui to not depend on WorkbenchHelp, which has been deleted from platform
Product:	[WebTools] WTP Source Editing	Reporter:	Nick Boldt <nboldt>
Component:	wst.xml	Assignee:	Nitin Dahyabhai <thatnitind>
Status:	RESOLVED FIXED	QA Contact:	Nitin Dahyabhai <thatnitind>
Severity:	blocker
Priority:	P1	CC:	Lars.Vogel
Version:	unspecified
Target Milestone:	3.10 (Photon)
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	442959, 442961
Bug Blocks:

Description Nick Boldt

2018-02-16 08:43:12 EST

WorkbenchHelp is a class deprecated 15 years ago and marked for deletion for 2+ years ago. It was removed here:

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3b446863d5997a89af3aabe4fb5842d9c959826d

Happy Valentines Day to WTP! 

Now the SSE and releng.aggregator builds are failing because of this:

[ERROR] The import org.eclipse.ui.help.WorkbenchHelp cannot be resolved

Could someone from SSE update webtools.sourceediting/xml/bundles/org.eclipse.wst.xsd.ui to not depend on WorkbenchHelp ?

Comment 1 Nick Boldt

2018-02-16 08:54:25 EST

Here's the full error:

https://paste.fedoraproject.org/paste/BTSxR85exjR4lMg8Q2o7Tw

Comment 2 Nitin Dahyabhai

2018-02-17 01:55:02 EST

Updated.

Comment 3 Nick Boldt

2018-05-03 14:29:13 EDT

(02:26:53 PM) nboldt: commit 9efd0699422409335c34f949c50e5c5beb983ef7
(02:26:53 PM) nboldt: Author: Nitin Dahyabhai <nitind@pobox.com>
(02:26:53 PM) nboldt: Date:   Sat Feb 17 01:49:32 2018 -0500
(02:26:53 PM) nboldt:     [531277] remove references to WorkbenchHelp implementation class

(02:27:51 PM) nboldt: https://git.eclipse.org/r/plugins/gitiles/sourceediting/webtools.sourceediting/+/9efd0699422409335c34f949c50e5c5beb983ef7

In case someone was looking for the commit that fixed this.