Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 531099

Summary:	[10] Invalid @since 3.15 tag on JavaCore.VERSION_10
Product:	[Eclipse Project] JDT	Reporter:	Noopur Gupta <noopur_gupta>
Component:	Core	Assignee:	JDT-Core-Inbox <jdt-core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, jarthana, manoj.palat
Version:	4.8
Target Milestone:	BETA J18.3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/117372 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=d09788c534bc944024a06e74e947a86c2ee3a590 https://git.eclipse.org/r/117630 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=7e9cc1f18333cb9cc7c4f883c0fdb039569120f0
Whiteboard:

Description Noopur Gupta

2018-02-13 08:02:01 EST

Pulling the latest changes from jdt.core BETA_JAVA_18_3 branch gives error on JavaCore.VERSION_10:

Invalid @since 3.15 tag on VERSION_10; expecting @since 3.13

Also, shouldn't it be "@since 3.x BETA_JAVA_18_3" or is it OK to skip "BETA_JAVA_18_3" part?

Comment 1 Noopur Gupta

2018-02-13 08:05:46 EST

I also don't see any "early-draft" disclaimer in the copyright header. Isn't it still a requirement? 

Just want to clarify to follow the same in jdt.ui also.

Comment 2 Dani Megert

2018-02-13 09:15:12 EST

The @since tag must be the one we use for Photon (3.14 for JDT Core). Obviously you have to add an API Problem filter.

The disclaimer must be added to every file that has Java 10 specific changes.

Comment 3 Eclipse Genie

2018-02-14 11:37:04 EST

New Gerrit change created: https://git.eclipse.org/r/117372

Comment 4 Eclipse Genie

2018-02-14 21:23:16 EST

Gerrit change https://git.eclipse.org/r/117372 was merged to [BETA_JAVA_18_3].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=d09788c534bc944024a06e74e947a86c2ee3a590

Comment 5 Eclipse Genie

2018-02-19 02:05:14 EST

New Gerrit change created: https://git.eclipse.org/r/117630

Comment 6 Sasikanth Bharadwaj

2018-02-19 02:07:25 EST

(In reply to comment #5)
> New Gerrit change created: https://git.eclipse.org/r/117630
I found a few more instances where the since tag was wrong or was missing the BETA_JAVA_18_3 part or a file was missing the disclaimer, which I've corrected with the above patch. @Jay/@Manoj, would urge you to take a look to ensure I've not mi(e)ssed any :-)

Comment 7 Eclipse Genie

2018-02-20 05:18:35 EST

Gerrit change https://git.eclipse.org/r/117630 was merged to [BETA_JAVA_18_3].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=7e9cc1f18333cb9cc7c4f883c0fdb039569120f0