Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 531053

Summary: [Papyrus] [Moka] There is no possibility to push a new master branch
Product: Community Reporter: Quentin Le Menez <quentin.lemenez>
Component: GitAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: jeremie.tatibouet
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Quentin Le Menez CLA 2018-02-12 09:52:57 EST
Hi,

Disposing of the old moka-master branch was easy but it seems that, although that was possible, it deleted the old master branch as well and I can't seem to be able to push the new master either.
Where can I be granted the rights to do so ?

Gerrit seems to point in one direction but that does not seems to do the trick. as we get a token error when following the sent link.

here is the git error:
$ git push gerrit master
Counting objects: 591, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (229/229), done.
Writing objects: 100% (591/591), 102.65 KiB | 17.11 MiB/s, done.
Total 591 (delta 233), reused 493 (delta 135)
remote: Resolving deltas: 100% (233/233)
remote: Processing changes: refs: 1, done
remote:
remote: ERROR:  In commit 23e782b0d88e4dafbc93fbb817c5e4151a8a2efc
remote: ERROR:  committer email address jeremie.tatibouet@cea.fr
remote: ERROR:  does not match your user account.
remote: ERROR:
remote: ERROR:  The following addresses are currently registered:
remote: ERROR:    quentin.lemenez@cea.fr
remote: ERROR:
remote: ERROR:  To register an email address, please visit:
remote: ERROR:  https://git.eclipse.org/r/#/settings/contact
remote:
remote:
To ssh://git.eclipse.org:29418/papyrus/org.eclipse.papyrus-moka
 ! [remote rejected] master -> master (invalid committer)
error: failed to push some refs to 'ssh://qlemenez@git.eclipse.org:29418/papyrus/org.eclipse.papyrus-moka'


Thanks,
Quentin
Comment 1 Quentin Le Menez CLA 2018-02-12 10:17:24 EST
Just an update as to let you know that going through Jeremie it went as planned and the new master has been created, but I would still like to have the rights on this (and possibly on all other Papyrus repositories) repository.

Thanks,
Quentin
Comment 2 Eclipse Webmaster CLA 2018-02-12 14:19:06 EST
The issue with your push is that you can't push commits that belong to other people.  

-M.
Comment 3 Quentin Le Menez CLA 2018-02-13 08:01:10 EST
ha !
you mean to say that I could not push the master branch because there were commits on it that did not belong to me ?
Is it because I am not considered a committer on this project ? that would be strange as I am one on the Papyrus one, or maybe there are permissions distinct to all the git repository created under the Papyrus project ?

Quentin
Comment 4 Eclipse Webmaster CLA 2018-02-13 17:01:00 EST
(In reply to Quentin Le Menez from comment #3)

> you mean to say that I could not push the master branch because there were
> commits on it that did not belong to me ?
> Is it because I am not considered a committer on this project ? that would
> be strange as I am one on the Papyrus one, or maybe there are permissions
> distinct to all the git repository created under the Papyrus project ?
> 

The Eclipse IP check plugin checks that all commits being submitted belong to the same person, regardless of branch.  Committer status doesn't provide an 'override' of this requirement.

Permissions should be the same across all of a given projects repos.  If you believe that isn't the case let me know which repos you think should be checked.

-M.
Comment 5 Quentin Le Menez CLA 2018-02-14 09:07:49 EST
Hi,

To resume what was done on the repo org.eclipse.papyrus-moka.git :
I deleted the moka-master branch (which resulted in the deletion of the master branch for some reason. the former was based on the later), than proceeded to push the renamed local branch (moka-master -> master) to the remote.
This was denied with the associated message in comment#1.

I looked at the Moka repository and there were contributions from multiple people (mostly jeremie and sebatien). 
What was puzzling me was that Jeremie could push the new "master" branch (containing all the commits) and not me. Could it be that, because Sebastien was not a committer and Jeremie merged them for him that those commits were considered to be Jeremie's ?

Thanks and sorry for the hassle.
Quentin
Comment 6 Eclipse Webmaster CLA 2018-02-14 10:42:03 EST
(In reply to Quentin Le Menez from comment #5)
>. Could it be that, because Sebastien
> was not a committer and Jeremie merged them for him that those commits were
> considered to be Jeremie's ?

I would expect that to fail in the same way as your error, but I'm not a Git wizard.  Looking at the permissions I suspect Jeremie was leveraging 'force-push' to re-write the history.  We don't grant force push by default so I've removed that permission.

-M.
Comment 7 Quentin Le Menez CLA 2018-02-19 04:30:37 EST
Ok thanks it must have ben that then.
I'll close this as the issue has virually been resolved.