Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530990

Summary: Add DOT Attribute support for arrowhead="" and arrowtail=""
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.0.100 (Photon) M6   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Attachments:
Description Flags
Screenshot displaying the GEF DOT Graph view error message none

Description Tamas Miklossy CLA 2018-02-10 06:39:04 EST
Created attachment 272631 [details]
Screenshot displaying the GEF DOT Graph view error message

Rendering the following dot file 

digraph {
	1->2
	edge[arrowhead=vee]
	3->4
}

within the DOT Graph view results in the following error message:  Could not import DOT: Cannot set edge attribute 'arrowhead' to ''. The value '' is not a syntactically correct arrowType.

Although this is not documented explicitly, empty arrowhead/arrowtail attributes seemsto be used/supported by the dot language, especially if the dot file is generated by Graphviz.
Comment 1 Tamas Miklossy CLA 2018-02-10 06:52:21 EST
I pushed the following changes to origin/master:

[530990] Ensure that the DOT Editor/View accepts empty arrowtypes.

- Modify the DotArrowType.xtext grammar to accept an empty arrowtype
value, such as arrowhead="" and arrowtail="".
- Adapt the Dot2ZestAttributesConverter to use the default Zest
decoration in case of empty arrowtypes (same behaviour as in
graphviz).
- Implement corresponding DotArrowTypeTests, DotAttributesTests and
DotParserTests test cases.

Resolving as fixed in 5.0.100 (Photon) M6.